Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(78)

Side by Side Diff: test/cctest/heap/test-mark-compact.cc

Issue 2462553002: [heap] Do not wait for marking deque uncommit task on tear down. (Closed)
Patch Set: fix test 2 Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2012 the V8 project authors. All rights reserved. 1 // Copyright 2012 the V8 project authors. All rights reserved.
2 // Redistribution and use in source and binary forms, with or without 2 // Redistribution and use in source and binary forms, with or without
3 // modification, are permitted provided that the following conditions are 3 // modification, are permitted provided that the following conditions are
4 // met: 4 // met:
5 // 5 //
6 // * Redistributions of source code must retain the above copyright 6 // * Redistributions of source code must retain the above copyright
7 // notice, this list of conditions and the following disclaimer. 7 // notice, this list of conditions and the following disclaimer.
8 // * Redistributions in binary form must reproduce the above 8 // * Redistributions in binary form must reproduce the above
9 // copyright notice, this list of conditions and the following 9 // copyright notice, this list of conditions and the following
10 // disclaimer in the documentation and/or other materials provided 10 // disclaimer in the documentation and/or other materials provided
(...skipping 51 matching lines...) Expand 10 before | Expand all | Expand 10 after
62 } 62 }
63 63
64 while (!s.IsEmpty()) { 64 while (!s.IsEmpty()) {
65 Address value = s.Pop()->address(); 65 Address value = s.Pop()->address();
66 current_address -= kPointerSize; 66 current_address -= kPointerSize;
67 CHECK_EQ(current_address, value); 67 CHECK_EQ(current_address, value);
68 } 68 }
69 69
70 CHECK_EQ(original_address, current_address); 70 CHECK_EQ(original_address, current_address);
71 s.StopUsing(); 71 s.StopUsing();
72 CcTest::i_isolate()->cancelable_task_manager()->CancelAndWait();
72 s.TearDown(); 73 s.TearDown();
73 } 74 }
74 75
75 TEST(Promotion) { 76 TEST(Promotion) {
76 CcTest::InitializeVM(); 77 CcTest::InitializeVM();
77 Isolate* isolate = CcTest::i_isolate(); 78 Isolate* isolate = CcTest::i_isolate();
78 { 79 {
79 v8::HandleScope sc(CcTest::isolate()); 80 v8::HandleScope sc(CcTest::isolate());
80 Heap* heap = isolate->heap(); 81 Heap* heap = isolate->heap();
81 82
(...skipping 394 matching lines...) Expand 10 before | Expand all | Expand 10 after
476 477
477 478
478 TEST(RegressJoinThreadsOnIsolateDeinit) { 479 TEST(RegressJoinThreadsOnIsolateDeinit) {
479 intptr_t size_limit = ShortLivingIsolate() * 2; 480 intptr_t size_limit = ShortLivingIsolate() * 2;
480 for (int i = 0; i < 10; i++) { 481 for (int i = 0; i < 10; i++) {
481 CHECK_GT(size_limit, ShortLivingIsolate()); 482 CHECK_GT(size_limit, ShortLivingIsolate());
482 } 483 }
483 } 484 }
484 485
485 #endif // __linux__ and !USE_SIMULATOR 486 #endif // __linux__ and !USE_SIMULATOR
OLDNEW
« no previous file with comments | « src/heap/mark-compact.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698