Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(498)

Issue 246183003: DevTools Support for ServiceWoker. (Closed)

Created:
6 years, 8 months ago by horo
Modified:
6 years, 7 months ago
Reviewers:
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

DevTools Support for ServiceWoker. I'm splitting this into several patches. - https://codereview.chromium.org/252633003 Introduce worker_devtools_agent_route_id for EmbeddedWorker. (Closed) - https://codereview.chromium.org/251723002 Introduce EmbeddedWorkerDevToolsAgent. (Closed) - https://codereview.chromium.org/269653002 Rename SharedWorkerDevToolsManager to EmbeddedWorkerDevToolsManager. (Closed) - https://codereview.chromium.org/262773004 Add ServiceWorker support in EmbeddedWorkerDevToolsManager. (Closed) - https://codereview.chromium.org/268753004 Add WorkerScriptLoaded message to support attaching DevTools while starting ServiceWorker. (Closed) - https://codereview.chromium.org/251653003 Introduces DevToolsManagerDelegate. - https://codereview.chromium.org/261753008 Call EmbeddedWorkerDevToolsManager::ServiceWorkerCreated, WorkerContextStarted and WorkerDestroyed. - https://codereview.chromium.org/274743003 Add "inspect" button to chrome://serviceworker-internals. Demo movie: https://docs.google.com/file/d/0B2gpIRWE56A8UTdSdGJuVUxhRm8 BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : WorkerDevToolsManager #

Patch Set 4 : inspector #

Patch Set 5 : rebase #

Patch Set 6 : error fix #

Patch Set 7 : inspector #

Patch Set 8 : rebase #

Patch Set 9 : #

Patch Set 10 : #

Patch Set 11 : use EmbeddedWorkerContextMsg_MessageToInspectorController #

Patch Set 12 : #

Patch Set 13 : remove thread_id #

Patch Set 14 : #

Patch Set 15 : small fix #

Patch Set 16 : #

Patch Set 17 : move move service_worker_context_observer.h to content/browser/ and use CallbackList #

Patch Set 18 : revert gypi #

Patch Set 19 : Create NextRoutingIDCallback from widget_helper_ in RenderProcessHostImpl. Rename worker_route_id to worker_devtools_agent_route_id. #

Patch Set 20 : small fix #

Patch Set 21 : rename to worker_devtools_agent_route_id #

Patch Set 22 : content_unittests #

Patch Set 23 : #

Patch Set 24 : rebase #

Patch Set 25 : RenderProcessHostImpl::GetNextRoutingIDForProcess #

Patch Set 26 : small fix #

Patch Set 27 : Stop using CallbackList #

Patch Set 28 : rebase #

Patch Set 29 : #

Patch Set 30 : inspect html css #

Patch Set 31 : #

Patch Set 32 : To avoid making circular reference, use base::Unretained. to make statu_change_callback_. #

Patch Set 33 : comment #

Patch Set 34 : EmbeddedWorkerDevToolsAgent #

Patch Set 35 : WorkerWrapper::dev_tools_agent() #

Patch Set 36 : Remove RenderProcessHostImpl::GetNextRoutingIDForProcess #

Patch Set 37 : remove EmbeddedWorkerMsg_MessageToWorker and rename SharedWorkerRoute to EmbeddedWorkerRoute start … #

Patch Set 38 : rebase #

Patch Set 39 : rename embedded_worker_routes_ #

Patch Set 40 : remove embedded_worker_id #

Patch Set 41 : pause_on_start #

Patch Set 42 : small fix #

Patch Set 43 : ServiceWorkerInfo #

Patch Set 44 : rebase #

Patch Set 45 : ServiceWorkerContext::StatusChangeObserver #

Patch Set 46 : Rename SharedWorkerDevToolsManager to EmbeddedWorkerDevToolsManager. #

Patch Set 47 : #include <vector> #

Patch Set 48 : small fix #

Patch Set 49 : Add EmbeddedWorkerHostMsg_WorkerScriptLoaded to support attach devtools on start. #

Patch Set 50 : EmbeddedWorkerDevToolsManager #

Patch Set 51 : small fix #

Patch Set 52 : rebase #

Patch Set 53 : DevToolsManagerBridge #

Patch Set 54 : fix compile error #

Patch Set 55 : rebase #

Patch Set 56 : show in chrome://serviceworker-internals #

Patch Set 57 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+404 lines, -126 lines) Patch
M chrome/browser/chrome_content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/browser/chrome_content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 2 chunks +6 lines, -0 lines 0 comments Download
A chrome/browser/devtools/chrome_devtools_manager_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 1 chunk +25 lines, -0 lines 0 comments Download
A chrome/browser/devtools/chrome_devtools_manager_delegate.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +26 lines, -0 lines 0 comments Download
M chrome/browser/printing/cloud_print/test/cloud_print_proxy_process_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 4 chunks +13 lines, -0 lines 0 comments Download
M chrome/chrome_debugger.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_agent_host_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +4 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_manager_impl.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 3 chunks +7 lines, -0 lines 0 comments Download
M content/browser/devtools/devtools_manager_impl.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 3 chunks +10 lines, -1 line 0 comments Download
M content/browser/devtools/embedded_worker_devtools_manager.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 56 3 chunks +16 lines, -1 line 0 comments Download
M content/browser/resources/service_worker/serviceworker_internals.html View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/resources/service_worker/serviceworker_internals.js View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/embedded_worker_instance.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 6 chunks +34 lines, -14 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 4 chunks +159 lines, -20 lines 0 comments Download
M content/browser/service_worker/embedded_worker_instance_unittest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 6 chunks +3 lines, -8 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 2 chunks +4 lines, -14 lines 0 comments Download
M content/browser/service_worker/embedded_worker_registry.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 2 chunks +6 lines, -59 lines 0 comments Download
M content/browser/service_worker/service_worker_browsertest.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 2 chunks +3 lines, -3 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 2 chunks +4 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_context_core.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 1 chunk +5 lines, -2 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 3 chunks +27 lines, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_version.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 2 chunks +1 line, -2 lines 0 comments Download
M content/common/service_worker/embedded_worker_messages.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 1 chunk +1 line, -0 lines 0 comments Download
M content/content_browser.gypi View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +1 line, -0 lines 0 comments Download
M content/public/browser/content_browser_client.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 2 chunks +5 lines, -0 lines 0 comments Download
M content/public/browser/content_browser_client.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +4 lines, -0 lines 0 comments Download
M content/public/browser/devtools_agent_host.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +3 lines, -0 lines 0 comments Download
A content/public/browser/devtools_manager_delegate.h View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 49 50 51 52 53 54 55 1 chunk +24 lines, -0 lines 0 comments Download
M content/renderer/service_worker/embedded_worker_dispatcher.cc View 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 16 17 18 19 20 21 22 23 24 25 26 27 28 29 30 31 32 33 34 35 36 37 38 39 40 41 42 43 44 45 46 47 48 1 chunk +3 lines, -1 line 0 comments Download

Powered by Google App Engine
This is Rietveld 408576698