Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 274743003: Add "inspect" button to chrome://serviceworker-internals. (Closed)

Created:
6 years, 7 months ago by horo
Modified:
6 years, 7 months ago
Reviewers:
kinuko
CC:
chromium-reviews, michaeln, jsbell+serviceworker_chromium.org, tzik, serviceworker-reviews, jam, nhiroki, darin-cc_chromium.org, horo+watch_chromium.org, kinuko+watch, alecflett+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Add "inspect" button to chrome://serviceworker-internals. This cl depends on https://codereview.chromium.org/261753008 BUG=358657 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=271254

Patch Set 1 : #

Patch Set 2 : Use version id of ServiceWorker to open inspector #

Patch Set 3 : rebase #

Patch Set 4 : rebase and fix typo #

Unified diffs Side-by-side diffs Delta from patch set Stats (+89 lines, -1 line) Patch
M content/browser/resources/service_worker/serviceworker_internals.html View 1 chunk +2 lines, -0 lines 0 comments Download
M content/browser/resources/service_worker/serviceworker_internals.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.h View 1 chunk +1 line, -0 lines 0 comments Download
M content/browser/service_worker/service_worker_internals_ui.cc View 1 2 3 7 chunks +85 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (0 generated)
horo
kinuko@ Could you please review this?
6 years, 7 months ago (2014-05-13 04:26:00 UTC) #1
horo
kinuko@ Could you please review this?
6 years, 7 months ago (2014-05-13 04:26:01 UTC) #2
kinuko
lgtm
6 years, 7 months ago (2014-05-13 05:37:34 UTC) #3
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-13 09:05:15 UTC) #4
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 7 months ago (2014-05-13 09:05:16 UTC) #5
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-13 09:14:30 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/274743003/40001
6 years, 7 months ago (2014-05-13 09:15:27 UTC) #7
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 7 months ago (2014-05-13 09:16:09 UTC) #8
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-17 06:11:31 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/274743003/90001
6 years, 7 months ago (2014-05-17 06:12:26 UTC) #10
horo
The CQ bit was unchecked by horo@chromium.org
6 years, 7 months ago (2014-05-17 11:08:48 UTC) #11
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-17 11:08:50 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/274743003/90001
6 years, 7 months ago (2014-05-17 11:09:19 UTC) #13
commit-bot: I haz the power
6 years, 7 months ago (2014-05-17 18:36:41 UTC) #14
Message was sent while issue was closed. 
Change committed as 271254

Powered by Google App Engine
This is Rietveld 408576698