Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Issue 269653002: Rename SharedWorkerDevToolsManager to EmbeddedWorkerDevToolsManager. (Closed)

Created:
6 years, 7 months ago by horo
Modified:
6 years, 7 months ago
Reviewers:
yurys
CC:
chromium-reviews, vsevik, jam, yurys, paulirish+reviews_chromium.org, darin-cc_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org, pfeldman
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Visibility:
Public.

Description

Rename SharedWorkerDevToolsManager to EmbeddedWorkerDevToolsManager. EmbeddedWorkerDevToolsManager will be used not only for SharedWorker but also for ServiceWorker. BUG=358657 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=267801

Patch Set 1 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+126 lines, -730 lines) Patch
A + content/browser/devtools/embedded_worker_devtools_manager.h View 4 chunks +23 lines, -23 lines 0 comments Download
A + content/browser/devtools/embedded_worker_devtools_manager.cc View 13 chunks +34 lines, -28 lines 0 comments Download
A + content/browser/devtools/embedded_worker_devtools_manager_unittest.cc View 7 chunks +57 lines, -57 lines 0 comments Download
D content/browser/devtools/shared_worker_devtools_manager.h View 1 chunk +0 lines, -95 lines 0 comments Download
D content/browser/devtools/shared_worker_devtools_manager.cc View 1 chunk +0 lines, -250 lines 0 comments Download
D content/browser/devtools/shared_worker_devtools_manager_unittest.cc View 1 chunk +0 lines, -265 lines 0 comments Download
M content/browser/devtools/worker_devtools_manager.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/browser/shared_worker/shared_worker_host.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M content/browser/shared_worker/shared_worker_instance.h View 1 chunk +1 line, -1 line 0 comments Download
M content/browser/shared_worker/shared_worker_service_impl.cc View 2 chunks +2 lines, -2 lines 0 comments Download
M content/content_browser.gypi View 1 chunk +2 lines, -2 lines 0 comments Download
M content/content_tests.gypi View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
horo
yurys@ Could you please review this? This is one of the patches for DevTools support ...
6 years, 7 months ago (2014-05-01 06:41:29 UTC) #1
horo
yurys@ Could you please review this? This is one of the patches for DevTools support ...
6 years, 7 months ago (2014-05-01 06:41:31 UTC) #2
yurys
lgtm
6 years, 7 months ago (2014-05-02 04:23:11 UTC) #3
horo
The CQ bit was checked by horo@chromium.org
6 years, 7 months ago (2014-05-02 04:41:19 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/horo@chromium.org/269653002/10013
6 years, 7 months ago (2014-05-02 04:42:10 UTC) #5
commit-bot: I haz the power
6 years, 7 months ago (2014-05-02 16:05:12 UTC) #6
Message was sent while issue was closed.
Change committed as 267801

Powered by Google App Engine
This is Rietveld 408576698