Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 24616002: Clean up a few unused globals. (Closed)

Created:
7 years, 2 months ago by Nico
Modified:
7 years, 2 months ago
CC:
chromium-reviews, jamiewalch+watch_chromium.org, dcaiafa+watch_chromium.org, cbentzel+watch_chromium.org, gavinp+disk_chromium.org, hclam+watch_chromium.org, wez+watch_chromium.org, grt+watch_chromium.org, amit, sanjeevr, jam, gavinp+memory_chromium.org, joi+watch-content_chromium.org, garykac+watch_chromium.org, darin-cc_chromium.org, weitaosu+watch_chromium.org, rmsousa+watch_chromium.org, alexeypa+watch_chromium.org, erikwright+watch_chromium.org, sergeyu+watch_chromium.org, mmenke, lambroslambrou+watch_chromium.org, vrk (LEFT CHROMIUM)
Visibility:
Public.

Description

Clean up a few unused globals. Found by clang's new -Wunused-const-variable. BUG=290204 R=akalin@chromium.org, brettw@chromium.org, sergeyu@chromium.org, thestig@chromium.org Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=225235

Patch Set 1 #

Patch Set 2 : foo #

Patch Set 3 : net_unittests #

Patch Set 4 : win #

Total comments: 4
Unified diffs Side-by-side diffs Delta from patch set Stats (+30 lines, -279 lines) Patch
M base/file_util.cc View 2 chunks +0 lines, -3 lines 0 comments Download
M base/file_util_unittest.cc View 1 chunk +0 lines, -102 lines 0 comments Download
M base/memory/shared_memory_posix.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M base/message_loop/message_loop_unittest.cc View 1 1 chunk +3 lines, -1 line 0 comments Download
M base/process/process_util_unittest.cc View 1 3 chunks +1 line, -7 lines 0 comments Download
M base/test/test_launcher.cc View 1 1 chunk +0 lines, -2 lines 0 comments Download
M base/time/time_mac.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/common/chrome_paths.cc View 1 chunk +2 lines, -8 lines 2 comments Download
M chrome/common/chrome_switches.cc View 1 2 3 1 chunk +2 lines, -0 lines 0 comments Download
M chrome/common/pref_names.cc View 1 chunk +0 lines, -27 lines 0 comments Download
M chrome/installer/gcapi_mac/gcapi.mm View 1 chunk +0 lines, -3 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url2_test.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M content/test/plugin/plugin_get_javascript_url_test.cc View 1 chunk +2 lines, -4 lines 0 comments Download
M net/base/directory_lister.cc View 2 chunks +1 line, -2 lines 0 comments Download
M net/base/filter.cc View 1 chunk +0 lines, -6 lines 0 comments Download
M net/base/gzip_filter_unittest.cc View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
M net/cert/ev_root_ca_metadata.cc View 2 chunks +3 lines, -0 lines 0 comments Download
M net/cert/ev_root_ca_metadata_unittest.cc View 1 2 1 chunk +6 lines, -6 lines 0 comments Download
M net/cookies/cookie_monster_unittest.cc View 1 2 1 chunk +0 lines, -1 line 0 comments Download
M net/disk_cache/simple/simple_index_file.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/disk_cache/simple/simple_version_upgrade_unittest.cc View 1 2 1 chunk +0 lines, -6 lines 0 comments Download
M net/dns/dns_socket_pool.cc View 3 chunks +1 line, -13 lines 0 comments Download
M net/dns/host_resolver.cc View 1 chunk +0 lines, -3 lines 0 comments Download
M net/dns/serial_worker.cc View 2 chunks +1 line, -5 lines 0 comments Download
M net/http/transport_security_state_unittest.cc View 1 2 1 chunk +0 lines, -32 lines 0 comments Download
M net/proxy/proxy_config_service_mac.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/proxy/proxy_service.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M net/quic/crypto/aes_128_gcm_12_decrypter_nss.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/socks5_client_socket.cc View 1 chunk +0 lines, -1 line 0 comments Download
M net/socket/tcp_listen_socket_unittest.cc View 1 2 1 chunk +3 lines, -5 lines 0 comments Download
M net/socket/unix_domain_socket_posix_unittest.cc View 1 2 2 chunks +1 line, -1 line 0 comments Download
M net/spdy/spdy_websocket_test_util.cc View 1 2 1 chunk +4 lines, -6 lines 0 comments Download
M net/ssl/server_bound_cert_service.cc View 1 chunk +0 lines, -1 line 0 comments Download
M ppapi/native_client/src/trusted/plugin/plugin.cc View 2 chunks +0 lines, -5 lines 0 comments Download
M remoting/host/constants_mac.cc View 1 chunk +0 lines, -4 lines 2 comments Download

Messages

Total messages: 10 (0 generated)
Nico
This means adding #ifdefs around constants every now and then, but as this warning seems ...
7 years, 2 months ago (2013-09-25 17:05:45 UTC) #1
brettw
base and ppapi lgtm
7 years, 2 months ago (2013-09-25 17:43:07 UTC) #2
Sergey Ulanov
https://codereview.chromium.org/24616002/diff/13001/remoting/host/constants_mac.cc File remoting/host/constants_mac.cc (left): https://codereview.chromium.org/24616002/diff/13001/remoting/host/constants_mac.cc#oldcode20 remoting/host/constants_mac.cc:20: const char kUpdateSucceededNotificationName[] = Looks like the header also ...
7 years, 2 months ago (2013-09-25 18:04:43 UTC) #3
Sergey Ulanov
lgtm https://codereview.chromium.org/24616002/diff/13001/remoting/host/constants_mac.cc File remoting/host/constants_mac.cc (left): https://codereview.chromium.org/24616002/diff/13001/remoting/host/constants_mac.cc#oldcode20 remoting/host/constants_mac.cc:20: const char kUpdateSucceededNotificationName[] = On 2013/09/25 18:04:44, Sergey ...
7 years, 2 months ago (2013-09-25 18:06:35 UTC) #4
Lei Zhang
chrome/ lg pending vrk's response. https://codereview.chromium.org/24616002/diff/13001/chrome/common/chrome_paths.cc File chrome/common/chrome_paths.cc (left): https://codereview.chromium.org/24616002/diff/13001/chrome/common/chrome_paths.cc#oldcode67 chrome/common/chrome_paths.cc:67: const base::FilePath::CharType kEffectsPluginFileName[] = ...
7 years, 2 months ago (2013-09-25 19:13:10 UTC) #5
akalin
net lgtm
7 years, 2 months ago (2013-09-25 19:21:55 UTC) #6
Nico
Thanks! https://codereview.chromium.org/24616002/diff/13001/chrome/common/chrome_paths.cc File chrome/common/chrome_paths.cc (left): https://codereview.chromium.org/24616002/diff/13001/chrome/common/chrome_paths.cc#oldcode67 chrome/common/chrome_paths.cc:67: const base::FilePath::CharType kEffectsPluginFileName[] = On 2013/09/25 19:13:10, Lei ...
7 years, 2 months ago (2013-09-25 19:28:29 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/thakis@chromium.org/24616002/13001
7 years, 2 months ago (2013-09-25 19:44:20 UTC) #8
Lei Zhang
ok, lgtm then
7 years, 2 months ago (2013-09-25 19:45:59 UTC) #9
Nico
7 years, 2 months ago (2013-09-25 20:09:16 UTC) #10
Message was sent while issue was closed. 
Committed patchset #4 manually as r225235.

Powered by Google App Engine
This is Rietveld 408576698