Clean up a few unused globals.

remoting/host/constants_mac.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/constants_mac.h"
 
 namespace remoting {
 
 #define SERVICE_NAME "org.chromium.chromoting"
 
 #define APPLICATIONS_DIR "/Applications/"
 #define HELPER_TOOLS_DIR "/Library/PrivilegedHelperTools/"
 #define LAUNCH_AGENTS_DIR "/Library/LaunchAgents/"
 #define PREFERENCE_PANES_DIR "/Library/PreferencePanes/"
 #define LOG_DIR "/var/log/"
 #define LOG_CONFIG_DIR "/etc/newsyslog.d/"
 
 const char kServiceName[] = SERVICE_NAME;
 
-const char kUpdateSucceededNotificationName[] =

[Sergey Ulanov, 2013/09/25 18:04:44]

Looks like the header also defines UPDATE_SUCCEEDED_NOTIFICATION_NAME with the
same value. It should be replaced with this value. Please keep this file as is.
I'll remove UPDATE_SUCCEEDED_NOTIFICATION_NAME and
UPDATE_FAILED_NOTIFICATION_NAME and update code to use these two consts.

[Sergey Ulanov, 2013/09/25 18:06:35]

I take this back. these two strings need to be defined as macros per comments in
the header.

-    SERVICE_NAME ".update_succeeded";
-const char kUpdateFailedNotificationName[] = SERVICE_NAME ".update_failed";
-
 const char kPrefPaneFileName[] = SERVICE_NAME ".prefPane";
 const char kPrefPaneFilePath[] = PREFERENCE_PANES_DIR SERVICE_NAME ".prefPane";
 
 const char kHostConfigFileName[] = SERVICE_NAME ".json";
 const char kHostConfigFilePath[] = HELPER_TOOLS_DIR SERVICE_NAME ".json";
 
 const char kHostHelperScriptPath[] = HELPER_TOOLS_DIR SERVICE_NAME ".me2me.sh";
 const char kHostBinaryPath[] = HELPER_TOOLS_DIR SERVICE_NAME ".me2me_host.app";
 const char kHostEnabledPath[] = HELPER_TOOLS_DIR SERVICE_NAME ".me2me_enabled";
 
 const char kServicePlistPath[] = LAUNCH_AGENTS_DIR SERVICE_NAME ".plist";
 
 const char kLogFilePath[] = LOG_DIR SERVICE_NAME ".log";
 const char kLogFileConfigPath[] = LOG_CONFIG_DIR SERVICE_NAME ".conf";
 
 const char kNativeMessagingManifestPath[] =
     "/Library/Google/Chrome/NativeMessagingHosts/"
     "com.google.chrome.remote_desktop.json";
 
 const char kBrandedUninstallerPath[] = APPLICATIONS_DIR
     "Chrome Remote Desktop Host Uninstaller.app";
 const char kUnbrandedUninstallerPath[] = APPLICATIONS_DIR
     "Chromoting Host Uninstaller.app";
 
 }  // namespace remoting