[Devtools] Added timeline event dividers bars to network timeline exp

[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG=653738
Committed: https://crrev.com/034e2796aa34802260bd4841e7781a66b8b33ce6
Cr-Commit-Position: refs/heads/master@{#428539}

[allada, 2016-10-28 00:43:20]

Description was changed from

==========
[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG=653738
==========

[allada, 2016-10-28 00:43:38]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-28 00:43:59]

Patchset #1 (id:20001) has been deleted

[allada, 2016-10-28 00:44:10]

PTL

[allada, 2016-10-28 00:44:14]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 00:44:46]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 01:52:16]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 01:52:17]

Dry run: This issue passed the CQ dry run.

[dgozman, 2016-10-28 18:35:38]

lgtm

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:38:
this._shownEventDividers = new Map();
Why not just |_eventDividers|? The naming is confusing between this and boolean
flag below.

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:361:
context.scale(window.devicePixelRatio, window.devicePixelRatio);
Do this scaling just once at the top of draw.

[allada, 2016-10-28 21:08:17]

Patchset #2 (id:60001) has been deleted

[allada, 2016-10-28 21:09:07]

done

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(right):

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:38:
this._shownEventDividers = new Map();
On 2016/10/28 18:35:38, dgozman wrote:
> Why not just |_eventDividers|? The naming is confusing between this and
boolean
> flag below.

Done.

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js
(right):

https://codereview.chromium.org/2461573002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkTimelineColumn.js:361:
context.scale(window.devicePixelRatio, window.devicePixelRatio);
On 2016/10/28 18:35:38, dgozman wrote:
> Do this scaling just once at the top of draw.

Done.

[allada, 2016-10-28 21:09:12]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-28 21:09:12]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2461573002/#ps80001
(title: "changes")

[commit-bot: I haz the power, 2016-10-28 21:09:38]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:19:53]

Description was changed from

==========
[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG=653738
==========

[commit-bot: I haz the power, 2016-10-28 23:19:54]

Committed patchset #2 (id:80001)

[commit-bot: I haz the power, 2016-10-28 23:21:49]

Description was changed from

==========
[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Added timeline event dividers bars to network timeline exp

This patch adds the ability to hover over film strip and a yellow bar will
appear in timeline. Page load and first paint bars will also show.

see: http://imgur.com/a/RVRrc

R=dgozman
BUG=653738

Committed: https://crrev.com/034e2796aa34802260bd4841e7781a66b8b33ce6
Cr-Commit-Position: refs/heads/master@{#428539}
==========

[commit-bot: I haz the power, 2016-10-28 23:21:50]

Patchset 2 (id:??) landed as
https://crrev.com/034e2796aa34802260bd4841e7781a66b8b33ce6
Cr-Commit-Position: refs/heads/master@{#428539}