[Devtools] Added contextmenu item to allow different timeline styles for exp

[Devtools] Added contextmenu item to allow different timeline styles for exp

This patch adds the ability to go between modes in the header context menu
for the network timeline experiment.

See: http://imgur.com/a/8qGxd

R=dgozman
BUG=653738
Committed: https://crrev.com/c8db439df7b58acd8db359b9fd78d649e7a13582
Cr-Commit-Position: refs/heads/master@{#428545}

[allada, 2016-10-28 02:02:29]

Patchset #1 (id:1) has been deleted

[allada, 2016-10-28 03:32:42]

Patchset #2 (id:40001) has been deleted

[allada, 2016-10-28 03:33:36]

Patchset #1 (id:20001) has been deleted

[allada, 2016-10-28 03:35:02]

PTL

[allada, 2016-10-28 03:35:40]

allada@chromium.org changed reviewers:
+ chowse@chromium.org

[allada, 2016-10-28 03:35:41]

+chowse, can I get an lgtm from you too?

[dgozman, 2016-10-28 19:04:28]

Code lgtm, deferring to Chris on UI.

https://codereview.chromium.org/2454893004/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(left):

https://codereview.chromium.org/2454893004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:718:
visibleColumns[columnConfig.id] = (columnConfig.visible ||
!columnConfig.hideable);
What about name column? It's not hideable as well.

[chowse, 2016-10-28 19:11:51]

I'd suggest "Timeline" for the label instead of "Timeline Views"
(http://i.imgur.com/svk6BNX.jpg). Otherwise, LGTM.

On 2016/10/28 19:04:28, dgozman wrote:
> Code lgtm, deferring to Chris on UI.
> 
>
https://codereview.chromium.org/2454893004/diff/60001/third_party/WebKit/Sour...
> File
> third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
> (left):
> 
>
https://codereview.chromium.org/2454893004/diff/60001/third_party/WebKit/Sour...
>
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:718:
> visibleColumns[columnConfig.id] = (columnConfig.visible ||
> !columnConfig.hideable);
> What about name column? It's not hideable as well.

[allada, 2016-10-28 21:11:04]

done

https://codereview.chromium.org/2454893004/diff/60001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js
(left):

https://codereview.chromium.org/2454893004/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/devtools/front_end/network/NetworkLogViewColumns.js:718:
visibleColumns[columnConfig.id] = (columnConfig.visible ||
!columnConfig.hideable);
On 2016/10/28 19:04:28, dgozman wrote:
> What about name column? It's not hideable as well.

This is already handled by not allowing it to be hidden. This was a second check
to make sure the settings were not forced into a "hidden" mode, but I don't
think we need it and would make the code more complex to try and add an
exception for timeline.

[allada, 2016-10-28 21:11:15]

Patchset #2 (id:80001) has been deleted

[allada, 2016-10-28 21:11:20]

The CQ bit was checked by allada@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 21:11:42]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:02:09]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 23:02:10]

Dry run: This issue passed the CQ dry run.

[allada, 2016-10-28 23:26:58]

The CQ bit was checked by allada@chromium.org

[allada, 2016-10-28 23:26:59]

The patchset sent to the CQ was uploaded after l-g-t-m from chowse@chromium.org,
dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/2454893004/#ps100001
(title: "Merge branch 'TIMELINE_DIVIDERS' into TIMELINE_TIMING_BARS")

[commit-bot: I haz the power, 2016-10-28 23:27:15]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 23:33:14]

Committed patchset #2 (id:100001)

[commit-bot: I haz the power, 2016-10-28 23:37:55]

Description was changed from

==========
[Devtools] Added contextmenu item to allow different timeline styles for exp

This patch adds the ability to go between modes in the header context menu
for the network timeline experiment.

See: http://imgur.com/a/8qGxd

R=dgozman
BUG=653738
==========

to

==========
[Devtools] Added contextmenu item to allow different timeline styles for exp

This patch adds the ability to go between modes in the header context menu
for the network timeline experiment.

See: http://imgur.com/a/8qGxd

R=dgozman
BUG=653738

Committed: https://crrev.com/c8db439df7b58acd8db359b9fd78d649e7a13582
Cr-Commit-Position: refs/heads/master@{#428545}
==========

[commit-bot: I haz the power, 2016-10-28 23:37:56]

Patchset 2 (id:??) landed as
https://crrev.com/c8db439df7b58acd8db359b9fd78d649e7a13582
Cr-Commit-Position: refs/heads/master@{#428545}