Issue 2464683002: adds std:: to stl types (#049)

Issue 2464683002: adds std:: to stl types (#049) (Closed)

Created:
4 years, 1 month ago by Buck

Modified:
4 years, 1 month ago

Reviewers:
Ryan Hamilton

CC:
chromium-reviews, cbentzel+watch_chromium.org

Target Ref:
refs/pending/heads/master

Project:
chromium

Visibility:
Public.

More Reviews

Description

adds std:: to stl types (#049) in order to disable internal global using declarations, this CL qualifies stl types with std namespace. Merge internal change: 136850852 R=rch@chromium.org BUG=

Patch Set 2 : eradicate using::std::* #

Patch Set 3 : remove dead using std::foo declarations. #

Created: 4 years, 1 month ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+82 lines, -102 lines)			Patch
M	net/quic/core/quic_buffered_packet_store.cc	View	1	3 chunks	+6 lines, -7 lines	0 comments	Download
M	net/quic/core/quic_buffered_packet_store_test.cc	View	1 2	6 chunks	+5 lines, -6 lines	0 comments	Download
M	net/quic/core/quic_crypto_client_stream_test.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/quic/core/quic_crypto_server_stream_test.cc	View	1 2	2 chunks	+4 lines, -4 lines	0 comments	Download
M	net/quic/core/quic_crypto_stream_test.cc	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/quic/core/quic_data_writer.cc	View	1	3 chunks	+2 lines, -3 lines	0 comments	Download
M	net/quic/core/quic_framer.cc	View	1 2	10 chunks	+22 lines, -22 lines	0 comments	Download
M	net/quic/core/quic_packet_creator_test.cc	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download
M	net/quic/core/quic_packet_generator_test.cc	View	1 2	2 chunks	+1 line, -2 lines	0 comments	Download
M	net/quic/core/quic_protocol.h	View		1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/core/quic_received_packet_manager.cc	View	1 2	3 chunks	+2 lines, -3 lines	0 comments	Download
M	net/quic/core/quic_received_packet_manager_test.cc	View	1	4 chunks	+4 lines, -7 lines	0 comments	Download
M	net/quic/core/quic_session.cc	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	net/quic/core/quic_session_test.cc	View	1 2	2 chunks	+1 line, -3 lines	0 comments	Download
M	net/quic/core/quic_stream_sequencer.cc	View	1 2	3 chunks	+3 lines, -3 lines	0 comments	Download
M	net/quic/core/quic_stream_sequencer_buffer.cc	View	2	1 chunk	+1 line, -1 line	0 comments	Download
M	net/quic/core/quic_stream_sequencer_test.cc	View	1 2	9 chunks	+12 lines, -15 lines	0 comments	Download
M	net/quic/core/spdy_utils.cc	View	2	1 chunk	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/end_to_end_test.cc	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher.cc	View	2	2 chunks	+2 lines, -2 lines	0 comments	Download
M	net/tools/quic/quic_dispatcher_test.cc	View	1 2	3 chunks	+4 lines, -5 lines	0 comments	Download
M	net/tools/quic/stateless_rejector_test.cc	View	1 2	2 chunks	+2 lines, -3 lines	0 comments	Download

Depends on Patchset:

Issue 2460223002 Patch 60001

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

Ryan Hamilton

lgtm https://codereview.chromium.org/2464683002/diff/1/net/quic/core/quic_buffered_packet_store.cc File net/quic/core/quic_buffered_packet_store.cc (left): https://codereview.chromium.org/2464683002/diff/1/net/quic/core/quic_buffered_packet_store.cc#oldcode12 net/quic/core/quic_buffered_packet_store.cc:12: using std::list; If it's not too much work, ...

4 years, 1 month ago (2016-10-30 20:22:05 UTC) #2

Buck

4 years, 1 month ago (2016-10-30 23:53:17 UTC) #3

https://codereview.chromium.org/2464683002/diff/1/net/quic/core/quic_buffered...
File net/quic/core/quic_buffered_packet_store.cc (left):

https://codereview.chromium.org/2464683002/diff/1/net/quic/core/quic_buffered...
net/quic/core/quic_buffered_packet_store.cc:12: using std::list;
On 2016/10/30 20:22:05, Ryan Hamilton wrote:
> If it's not too much work, can you remove using std::foo from theses files?

Done.

Expand Messages | Collapse Messages