Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1561)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 245993002: Omnibox: Create Field Trial to Always Display Hint Text (Closed)

Created:
6 years, 8 months ago by Mark P
Modified:
6 years, 5 months ago
Reviewers:
Peter Kasting
CC:
chromium-reviews, tfarina, James Su
Visibility:
Public.

Description

Omnibox: Create Field Trial to Always Display Hint Text This likely won't affect metrics much, but someone asked me to do it so I am. It's easy. BUG=350200 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=282194

Patch Set 1 #

Total comments: 2

Patch Set 2 : rebase and add mac implementation #

Total comments: 2

Patch Set 3 : of->if #

Unified diffs Side-by-side diffs Delta from patch set Stats (+24 lines, -2 lines) Patch
M chrome/browser/omnibox/omnibox_field_trial.h View 1 2 2 chunks +10 lines, -0 lines 0 comments Download
M chrome/browser/omnibox/omnibox_field_trial.cc View 1 2 chunks +8 lines, -0 lines 0 comments Download
M chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm View 1 2 chunks +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/omnibox/omnibox_view_views.cc View 1 2 chunks +3 lines, -1 line 0 comments Download

Messages

Total messages: 9 (0 generated)
Mark P
ptal
6 years, 8 months ago (2014-04-22 23:37:33 UTC) #1
Peter Kasting
https://codereview.chromium.org/245993002/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/245993002/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode233 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:233: set_placeholder_text(GetHintText()); See bug 363805: This will probably result in ...
6 years, 8 months ago (2014-04-22 23:40:21 UTC) #2
Mark P
https://codereview.chromium.org/245993002/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc File chrome/browser/ui/views/omnibox/omnibox_view_views.cc (right): https://codereview.chromium.org/245993002/diff/1/chrome/browser/ui/views/omnibox/omnibox_view_views.cc#newcode233 chrome/browser/ui/views/omnibox/omnibox_view_views.cc:233: set_placeholder_text(GetHintText()); On 2014/04/22 23:40:21, Peter Kasting wrote: > See ...
6 years, 8 months ago (2014-04-22 23:42:54 UTC) #3
Mark P
Now that the blocking bug has been fixed, I think this is again ready for ...
6 years, 5 months ago (2014-07-08 19:40:20 UTC) #4
Peter Kasting
LGTM https://codereview.chromium.org/245993002/diff/20001/chrome/browser/omnibox/omnibox_field_trial.h File chrome/browser/omnibox/omnibox_field_trial.h (right): https://codereview.chromium.org/245993002/diff/20001/chrome/browser/omnibox/omnibox_field_trial.h#newcode316 chrome/browser/omnibox/omnibox_field_trial.h:316: // Returns true of the omnibox should display ...
6 years, 5 months ago (2014-07-09 01:14:41 UTC) #5
Mark P
https://codereview.chromium.org/245993002/diff/20001/chrome/browser/omnibox/omnibox_field_trial.h File chrome/browser/omnibox/omnibox_field_trial.h (right): https://codereview.chromium.org/245993002/diff/20001/chrome/browser/omnibox/omnibox_field_trial.h#newcode316 chrome/browser/omnibox/omnibox_field_trial.h:316: // Returns true of the omnibox should display hint ...
6 years, 5 months ago (2014-07-09 19:22:16 UTC) #6
Mark P
The CQ bit was checked by mpearson@chromium.org
6 years, 5 months ago (2014-07-09 19:22:20 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/mpearson@chromium.org/245993002/40001
6 years, 5 months ago (2014-07-09 19:24:15 UTC) #8
commit-bot: I haz the power
6 years, 5 months ago (2014-07-10 00:38:33 UTC) #9
Message was sent while issue was closed. 
Change committed as 282194

Powered by Google App Engine
This is Rietveld 408576698