Omnibox: Create Field Trial to Always Display Hint Text

chrome/browser/omnibox/omnibox_field_trial.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 #define CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_
 
 #include <map>
 #include <string>
 #include <vector>
@@ skipping 292 matching lines @@
   // (if valid and reasonable) even if the provider has good inline
   // autocompletions to offer.  Normally HistoryURL does not add the UWYT match
   // if there are good inline autocompletions, as the user could simply hit
   // backspace to delete the completion and get the what-you-typed match.
   // However, for the disabling inlining experiment we want to have the UWYT
   // always explicitly displayed at an option if possible.  Returns false if
   // the experiment isn't active.
   static bool AddUWYTMatchEvenIfPromotedURLs();
 
   // ---------------------------------------------------------
+  // For the DisplayHintTextWhenPossible experiment that's part of the
+  // bundled omnibox field trial.
+
+  // Returns true of the omnibox should display hint text (Search

[Peter Kasting, 2014/07/09 01:14:41]

Nit: of -> if

(I passed your secret test to see if I was reading the boring parts of the CL)

[Mark P, 2014/07/09 19:22:16]

Done.
:-)

+  // <search engine> or type URL) when possible (i.e., the omnibox
+  // is otherwise non-empty).
+  static bool DisplayHintTextWhenPossible();
+
+  // ---------------------------------------------------------
   // Exposed publicly for the sake of unittests.
   static const char kBundledExperimentFieldTrialName[];
   // Rule names used by the bundled experiment.
   static const char kShortcutsScoringMaxRelevanceRule[];
   static const char kSearchHistoryRule[];
   static const char kDemoteByTypeRule[];
   static const char kHQPBookmarkValueRule[];
   static const char kHQPDiscountFrecencyWhenFewVisitsRule[];
   static const char kHQPAllowMatchInTLDRule[];
   static const char kHQPAllowMatchInSchemeRule[];
   static const char kZeroSuggestRule[];
   static const char kZeroSuggestVariantRule[];
   static const char kBookmarksIndexURLsRule[];
   static const char kDisableInliningRule[];
   static const char kAnswersInSuggestRule[];
   static const char kAddUWYTMatchEvenIfPromotedURLsRule[];
+  static const char kDisplayHintTextWhenPossibleRule[];
 
   // Parameter names used by the HUP new scoring experiments.
   static const char kHUPNewScoringEnabledParam[];
   static const char kHUPNewScoringTypedCountRelevanceCapParam[];
   static const char kHUPNewScoringTypedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringTypedCountScoreBucketsParam[];
   static const char kHUPNewScoringVisitedCountRelevanceCapParam[];
   static const char kHUPNewScoringVisitedCountHalfLifeTimeParam[];
   static const char kHUPNewScoringVisitedCountScoreBucketsParam[];
 
@@ skipping 16 matching lines @@
   // prioritize different wildcard contexts, see the implementation.  How to
   // interpret the value is left to the caller; this is rule-dependent.
   static std::string GetValueForRuleInContext(
       const std::string& rule,
       metrics::OmniboxEventProto::PageClassification page_classification);
 
   DISALLOW_IMPLICIT_CONSTRUCTORS(OmniboxFieldTrial);
 };
 
 #endif  // CHROME_BROWSER_OMNIBOX_OMNIBOX_FIELD_TRIAL_H_