chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm - Issue 245993002: Omnibox: Create Field Trial to Always Display Hint Text

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

Issue 245993002: Omnibox: Create Field Trial to Always Display Hint Text (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: of->if Created 6 years, 5 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

diff --git a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

index 72c38033e24a52768301cb0ad20825a9a097a7c4..b496a0e0cf7ac248a440b92b41f894d48f103608 100644

--- a/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

+++ b/chrome/browser/ui/cocoa/omnibox/omnibox_view_mac.mm

@@ -14,6 +14,7 @@

#include "chrome/browser/autocomplete/autocomplete_match.h"

#include "chrome/browser/autocomplete/chrome_autocomplete_scheme_classifier.h"

#include "chrome/browser/browser_process.h"

+#include "chrome/browser/omnibox/omnibox_field_trial.h"

#include "chrome/browser/search/search.h"

#include "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_cell.h"

#import "chrome/browser/ui/cocoa/location_bar/autocomplete_text_field_editor.h"

@@ -234,7 +235,8 @@ void OmniboxViewMac::Update() {

}

void OmniboxViewMac::UpdatePlaceholderText() {

- if (chrome::ShouldDisplayOriginChip()) {

+ if (chrome::ShouldDisplayOriginChip() ||

+ OmniboxFieldTrial::DisplayHintTextWhenPossible()) {

NSDictionary* placeholder_attributes = @{

NSFontAttributeName : GetFieldFont(gfx::Font::NORMAL),

NSForegroundColorAttributeName : [NSColor disabledControlTextColor]