Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2459813003:
Convert Site Isolation Win bot to --isolate-extensions. (Closed)
DescriptionConvert Site Isolation Win bot to --isolate-extensions.
The --isolate-extension feature is not enabled by default for now, so
convert the bot to ensure we have test coverage for it.
BUG=545200
Committed: https://crrev.com/500b39f98671c820f3a519b30e49e0d6e860dc64
Cr-Commit-Position: refs/heads/master@{#428848}
Patch Set 1 #
Total comments: 2
Patch Set 2 : Move to different flags for content/extension tests. #Messages
Total messages: 22 (12 generated)
nasko@chromium.org changed reviewers: + alexmos@chromium.org
Hey Alex, Can you review this CL for me? It puts back the Windows bot to test with --isolate-extensions. Thanks in advance! Nasko
One comment below. Also, we will need to also update the layout test config, which is kept separately in the recipes. See https://codereview.chromium.org/2300853003. Maybe reverting that CL would work also? If not, you'll need to update the recipe in the build repo and rerun the recipe generation (or let me know and I can do it). https://codereview.chromium.org/2459813003/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2459813003/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:11645: "--isolate-extensions", This won't work for content_browsertests. We used to have this and several other tests set to --isolate-sites-for-testing=*.is and --isolate-sites-for-testing=chrome-extension://* instead -- see https://codereview.chromium.org/2295843004. Maybe just revert that CL?
The layout test config cannot be part of this CL, right? https://codereview.chromium.org/2459813003/diff/1/testing/buildbot/chromium.f... File testing/buildbot/chromium.fyi.json (right): https://codereview.chromium.org/2459813003/diff/1/testing/buildbot/chromium.f... testing/buildbot/chromium.fyi.json:11645: "--isolate-extensions", On 2016/10/28 19:02:07, alexmos wrote: > This won't work for content_browsertests. We used to have this and several > other tests set to --isolate-sites-for-testing=*.is and > --isolate-sites-for-testing=chrome-extension://* instead -- see > https://codereview.chromium.org/2295843004. Maybe just revert that CL? I tried to revert it, but didn't work.
Thanks, LGTM!
On 2016/10/28 19:09:14, nasko (out until nov 4) wrote: > The layout test config cannot be part of this CL, right? Yes, it has to be done in the build repo. I've got that set up and can take care of it. (This change does need to land first.)
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: This issue passed the CQ dry run.
The CQ bit was checked by nasko@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: ios-simulator on master.tryserver.chromium.mac (JOB_FAILED, http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)
creis@chromium.org changed reviewers: + creis@chromium.org
LGTM. Is this safe to land now that r428775 has landed? Just want to make sure we still have test coverage somewhere for --isolate-extensions mode.
The CQ bit was checked by nasko@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Committed patchset #2 (id:20001)
Message was sent while issue was closed.
Description was changed from ========== Convert Site Isolation Win bot to --isolate-extensions. The --isolate-extension feature is not enabled by default for now, so convert the bot to ensure we have test coverage for it. BUG=545200 ========== to ========== Convert Site Isolation Win bot to --isolate-extensions. The --isolate-extension feature is not enabled by default for now, so convert the bot to ensure we have test coverage for it. BUG=545200 Committed: https://crrev.com/500b39f98671c820f3a519b30e49e0d6e860dc64 Cr-Commit-Position: refs/heads/master@{#428848} ==========
Message was sent while issue was closed.
Patchset 2 (id:??) landed as https://crrev.com/500b39f98671c820f3a519b30e49e0d6e860dc64 Cr-Commit-Position: refs/heads/master@{#428848}
Message was sent while issue was closed.
A revert of this CL (patchset #2 id:20001) has been created in https://codereview.chromium.org/2466933003/ by lukasza@chromium.org. The reason for reverting is: This CL is the most likely cause of linux_site_isolation purpleness (https://crbug.com/661447).. |
