Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(643)

Issue 2300853003: Convert Site Isolation Win layout tests to run with --site-per-process. (Closed)

Created:
4 years, 3 months ago by alexmos
Modified:
4 years, 3 months ago
Reviewers:
Dirk Pranke
CC:
chromium-reviews, infra-reviews+build_chromium.org, kjellander-cc_chromium.org, site-isolation-reviews_chromium.org
Target Ref:
refs/heads/master
Project:
build
Visibility:
Public.

Description

Convert Site Isolation Win layout tests to run with --site-per-process. Now that --isolate-extensions is on by default on trunk, there is no benefit in running the layout tests on the Site Isolation Win bot in that mode anymore. Convert it back to run tests with --site-per-process. BUG=417518, 477150 Committed: https://chromium.googlesource.com/chromium/tools/build/+/1b0324b4e3dfad7455edaf416134848245331167

Patch Set 1 #

Patch Set 2 : Fix expectations #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -4 lines) Patch
M scripts/slave/recipe_modules/chromium_tests/chromium_fyi.py View 1 1 chunk +2 lines, -2 lines 0 comments Download
M scripts/slave/recipes/chromium.expected/full_chromium_fyi_Site_Isolation_Win.json View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 11 (7 generated)
alexmos
Dirk, can you please take a look? This complements the chromium.fyi.json change in https://codereview.chromium.org/2295843004/
4 years, 3 months ago (2016-09-01 00:23:19 UTC) #6
Dirk Pranke
lgtm
4 years, 3 months ago (2016-09-01 03:21:36 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2300853003/20001
4 years, 3 months ago (2016-09-07 16:47:43 UTC) #9
commit-bot: I haz the power
4 years, 3 months ago (2016-09-07 16:51:21 UTC) #11
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/chromium/tools/build/+/1b0324b4e3dfad7455ed...

Powered by Google App Engine
This is Rietveld 408576698