Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(397)

Issue 2295843004: Convert Site Isolation Win bot back to --site-per-process. (Closed)

Created:
4 years, 3 months ago by alexmos
Modified:
4 years, 3 months ago
Reviewers:
Charlie Reis
CC:
chromium-reviews, site-isolation-reviews_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Convert Site Isolation Win bot back to --site-per-process. Now that --isolate-extensions is on by default on trunk, there is no benefit in running the Win bot in that mode anymore. Convert it back to run tests with --site-per-process. BUG=417518 Committed: https://crrev.com/0ab1f2dee0fc6dbe0550c86666cf13837d464590 Cr-Commit-Position: refs/heads/master@{#416745}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+15 lines, -15 lines) Patch
M testing/buildbot/chromium.fyi.json View 1 1 chunk +15 lines, -15 lines 0 comments Download

Messages

Total messages: 16 (11 generated)
alexmos
Hey Charlie, can you please take a look? This updates everything but the layout tests, ...
4 years, 3 months ago (2016-09-01 00:21:32 UTC) #8
Charlie Reis
Thanks! LGTM. I imagine we'll need to keep an eye on any layout tests that ...
4 years, 3 months ago (2016-09-01 17:32:34 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2295843004/20001
4 years, 3 months ago (2016-09-06 20:50:27 UTC) #13
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 3 months ago (2016-09-06 22:58:20 UTC) #14
commit-bot: I haz the power
4 years, 3 months ago (2016-09-06 23:00:43 UTC) #16
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/0ab1f2dee0fc6dbe0550c86666cf13837d464590
Cr-Commit-Position: refs/heads/master@{#416745}

Powered by Google App Engine
This is Rietveld 408576698