Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3501)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java

Issue 2459033002: 📰 Add a context menu to remove status items (Closed)
Patch Set: close the menu when the view is detached Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
index fefe69dd20e757b4050d649cb12f5414e2c1a816..d85060f73dcbcf079dc5f46e67e3a2e8ab7dda42 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java
@@ -308,6 +308,8 @@ void ensureIconIsAvailable(String pageUrl, String iconUrl, boolean isLargeIcon,
* displayed to the user.
*/
boolean isCurrentPage();
+
+ ContextMenuHandler.LifetimeManager getContextMenuLifetimeManager();
}
/**
@@ -1017,7 +1019,7 @@ private void buildMostVisitedItems(final String[] titles, final String[] urls,
offlineAvailable, i, source);
View view =
mMostVisitedDesign.createMostVisitedItemView(inflater, item, isInitialLoad);
- item.initView(view, mUseCardsUi ? mRecyclerView : mScrollView);
+ item.initView(view, mUseCardsUi ? mRecyclerView : mScrollView, mNewTabPageLayout);
}
mMostVisitedItems[i] = item;

Powered by Google App Engine
This is Rietveld 408576698