📰 Add a context menu to remove status items

chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java

Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
index 708c3b82cc23fe4084bd307f610d8fe3c53c0f7d..48f8f2400553440a82dbfb5a2f4a5583105561f4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/cards/NewTabPageAdapter.java
@@ -333,7 +333,7 @@ public NewTabPageViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
                 return new NewTabPageViewHolder(SpacingItem.createView(parent));
 
             case ItemViewType.STATUS:
-                return new StatusCardViewHolder(mRecyclerView, mUiConfig);
+                return new StatusCardViewHolder(mRecyclerView, mNewTabPageManager, mUiConfig);
 
             case ItemViewType.PROGRESS:
                 return new ProgressViewHolder(mRecyclerView);
@@ -342,7 +342,7 @@ public NewTabPageViewHolder onCreateViewHolder(ViewGroup parent, int viewType) {
                 return new ActionItem.ViewHolder(mRecyclerView, mNewTabPageManager, mUiConfig);
 
             case ItemViewType.PROMO:
-                return new SignInPromo.ViewHolder(mRecyclerView, mUiConfig);
+                return new SignInPromo.ViewHolder(mRecyclerView, mNewTabPageManager, mUiConfig);
 
             case ItemViewType.FOOTER:
                 return new Footer.ViewHolder(mRecyclerView, mNewTabPageManager);
@@ -529,6 +529,9 @@ public void dismissItem(int position) {
 
     private void dismissSection(SuggestionsSection section) {
         assert SnippetsConfig.isSectionDismissalEnabled();
+
+        announceItemRemoved("Status card removed"); // TODO
+
         mNewTabPageManager.getSuggestionsSource().dismissCategory(section.getCategory());
         removeSection(section);
     }
@@ -552,7 +555,7 @@ private void dismissSuggestion(int position) {
     }
 
     private void dismissPromo() {
-        // TODO(dgn): accessibility announcement.
+        announceItemRemoved("Sign in promo removed"); // TODO
         mSigninPromo.dismiss();
     }
 
@@ -629,4 +632,10 @@ private void announceItemRemoved(String suggestionTitle) {
         mRecyclerView.announceForAccessibility(mRecyclerView.getResources().getString(
                 R.string.ntp_accessibility_item_removed, suggestionTitle));
     }
+
+    @Override
+    public void onViewDetachedFromWindow(NewTabPageViewHolder holder) {
+        mNewTabPageManager.getContextMenuLifetimeManager().onViewModified(holder.itemView);

[dgn, 2016/11/10 19:44:02]

problem2: making actions a noop when tapped is kind of okay, but I tried to just
close the menu when it becomes irrelevant. Here, when it is removed from the
recycler view. For most likely I pass the above the fold view. as associated
view, so that when that one goes off the menu is closed.

TBD: check if it is necessary to do something in onBindViewHolder

+        super.onViewDetachedFromWindow(holder);
+    }
 }