Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2934)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java

Issue 2459033002: 📰 Add a context menu to remove status items (Closed)
Patch Set: close the menu when the view is detached Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
index 96fd23a15fa42186b54aef0d96bf01d474b3cc77..a9da413d446de3e7234aa77a0b79b6a5fd86a843 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPage.java
@@ -44,6 +44,7 @@
import org.chromium.chrome.browser.favicon.LargeIconBridge.LargeIconCallback;
import org.chromium.chrome.browser.metrics.StartupMetrics;
import org.chromium.chrome.browser.multiwindow.MultiWindowUtils;
+import org.chromium.chrome.browser.ntp.ContextMenuHandler.LifetimeManager;
import org.chromium.chrome.browser.ntp.LogoBridge.Logo;
import org.chromium.chrome.browser.ntp.LogoBridge.LogoObserver;
import org.chromium.chrome.browser.ntp.NewTabPageView.NewTabPageManager;
@@ -222,6 +223,7 @@ static void setMostVisitedSitesForTests(MostVisitedSites mostVisitedSitesForTest
private final NewTabPageManager mNewTabPageManager = new NewTabPageManager() {
private static final String NTP_OFFLINE_PAGES_FEATURE_NAME = "NTPOfflinePages";
+ private LifetimeManager mContextMenuLifetimeManager = new LifetimeManager();
private boolean isNtpOfflinePagesEnabled() {
return ChromeFeatureList.isEnabled(NTP_OFFLINE_PAGES_FEATURE_NAME);
@@ -648,6 +650,11 @@ public boolean isCurrentPage() {
if (mFakeboxDelegate == null) return false;
return mFakeboxDelegate.isCurrentPage(NewTabPage.this);
}
+
+ @Override
+ public ContextMenuHandler.LifetimeManager getContextMenuLifetimeManager() {
+ return mContextMenuLifetimeManager;
+ }
};
/**

Powered by Google App Engine
This is Rietveld 408576698