Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(66)

Unified Diff: tracing/tracing/ui/side_panel/file_size_stats_side_panel.html

Issue 2458873002: Improve usability of groupby-picker. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/side_panel/file_size_stats_side_panel.html
diff --git a/tracing/tracing/ui/side_panel/file_size_stats_side_panel.html b/tracing/tracing/ui/side_panel/file_size_stats_side_panel.html
index 21c7b307ee460679ff4df1682a17a217dfa8acec..6e87fbc8b9f2a9250487b74989c88a9380ab5a8e 100644
--- a/tracing/tracing/ui/side_panel/file_size_stats_side_panel.html
+++ b/tracing/tracing/ui/side_panel/file_size_stats_side_panel.html
@@ -77,7 +77,11 @@ found in the LICENSE file.
dataFn: function(eventStat) { return eventStat.title; }
}
];
- this.$.picker.defaultGroupKeys = ['phase', 'title'];
+ // If the picker did not restore currentGroupKeys from Settings,
+ // then set default currentGroupKeys.
+ if (this.$.picker.currentGroupKeys.length === 0) {
+ this.$.picker.currentGroupKeys = ['phase', 'title'];
+ }
this.$.picker.addEventListener('current-groups-changed',
this.updateContents_.bind(this));
},
« no previous file with comments | « tracing/tracing/ui/base/grouping_table_groupby_picker_test.html ('k') | tracing/tracing/value/ui/histogram_set_table.html » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698