Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(276)

Unified Diff: tracing/tracing/ui/base/grouping_table_groupby_picker_test.html

Issue 2458873002: Improve usability of groupby-picker. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
diff --git a/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html b/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
index 1bbbc4f20579b9dfbfbdfd8c898180999cbc6962..76eb12b210dddef5b6b93d8d96382918d6e6dae1 100644
--- a/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
+++ b/tracing/tracing/ui/base/grouping_table_groupby_picker_test.html
@@ -11,10 +11,10 @@ found in the LICENSE file.
'use strict';
tr.b.unittest.testSuite(function() {
- test('basic', function() {
+ test('groupby-picker', function() {
var picker = document.createElement(
'tr-ui-b-grouping-table-groupby-picker');
- picker.settingsKey = 'basic-test';
+ picker.settingsKey = 'tr-ui-b-grouping-table-groupby-picker-test';
picker.possibleGroups = [
{key: 'a', label: 'A'},
{key: 'b', label: 'B'},
@@ -22,39 +22,23 @@ tr.b.unittest.testSuite(function() {
{key: 'd', label: 'D'},
{key: 'e', label: 'E'}
];
- picker.defaultGroupKeys = ['a', 'b', 'd'];
this.addHTMLOutput(picker);
- });
- test('allGroupsAdded', function() {
- var picker = document.createElement(
- 'tr-ui-b-grouping-table-groupby-picker');
- picker.settingsKey = 'basic-test';
- picker.possibleGroups = [
- {key: 'a', label: 'A'},
- {key: 'b', label: 'B'},
- {key: 'c', label: 'C'},
- {key: 'd', label: 'D'},
- {key: 'e', label: 'E'}
- ];
- picker.defaultGroupKeys = ['a', 'b', 'c', 'd', 'e'];
- this.addHTMLOutput(picker);
- });
+ var keys = ['a', 'b', 'c', 'd', 'e'];
+ picker.currentGroupKeys = keys;
+ assert.deepEqual(keys, picker.currentGroupKeys);
- test('noGroupsAdded', function() {
- var picker = document.createElement(
- 'tr-ui-b-grouping-table-groupby-picker');
- picker.settingsKey = 'basic-test';
- picker.possibleGroups = [
- {key: 'a', label: 'A'},
- {key: 'b', label: 'B'},
- {key: 'c', label: 'C'},
- {key: 'd', label: 'D'},
- {key: 'e', label: 'E'}
- ];
- picker.defaultGroupKeys = [];
- this.addHTMLOutput(picker);
- });
+ var keys = ['e', 'd', 'c', 'b', 'a'];
+ picker.currentGroupKeys = keys;
+ assert.deepEqual(keys, picker.currentGroupKeys);
+
+ var keys = [];
+ picker.currentGroupKeys = keys;
+ assert.deepEqual(keys, picker.currentGroupKeys);
+ var keys = ['a', 'b', 'd'];
+ picker.currentGroupKeys = keys;
+ assert.deepEqual(keys, picker.currentGroupKeys);
+ });
});
</script>

Powered by Google App Engine
This is Rietveld 408576698