Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(100)

Unified Diff: tracing/tracing/value/ui/histogram_set_table.html

Issue 2458873002: Improve usability of groupby-picker. (Closed)
Patch Set: . Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « tracing/tracing/ui/side_panel/file_size_stats_side_panel.html ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tracing/tracing/value/ui/histogram_set_table.html
diff --git a/tracing/tracing/value/ui/histogram_set_table.html b/tracing/tracing/value/ui/histogram_set_table.html
index 18d98f77ef6d8b34bb06025783a1168c2a8f5326..026c9bb9ba7dec30e8f288b26fedcdd30f8475d7 100644
--- a/tracing/tracing/value/ui/histogram_set_table.html
+++ b/tracing/tracing/value/ui/histogram_set_table.html
@@ -362,9 +362,13 @@ tr.exportTo('tr.ui', function() {
this.$.picker.settingsKey = 'tr-v-ui-histogram-set-table-groupby-picker';
this.$.picker.possibleGroups = DEFAULT_POSSIBLE_GROUPS.slice();
- this.$.picker.defaultGroupKeys = [
- tr.v.HistogramSet.GROUPINGS.HISTOGRAM_NAME.key,
- tr.v.HistogramSet.GROUPINGS.STORY_NAME.key];
+ // If the picker did not restore currentGroupKeys from Settings,
+ // then set default currentGroupKeys.
+ if (this.$.picker.currentGroupKeys.length === 0) {
+ this.$.picker.currentGroupKeys = [
+ tr.v.HistogramSet.GROUPINGS.HISTOGRAM_NAME.key,
+ tr.v.HistogramSet.GROUPINGS.STORY_NAME.key];
+ }
this.$.picker.addEventListener('current-groups-changed',
this.currentGroupsChanged_.bind(this));
},
« no previous file with comments | « tracing/tracing/ui/side_panel/file_size_stats_side_panel.html ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698