Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7)

Issue 2458823002: Don't establish LayoutState for LayoutTableRow objects. (Closed)

Created:
4 years, 1 month ago by mstensho (USE GERRIT)
Modified:
4 years, 1 month ago
Reviewers:
dgrogan, eae
CC:
chromium-reviews, Manuel Rego, fs, eric.carlson_apple.com, Srirama, kouhei+svg_chromium.org, rwlbuis, krit, szager+layoutwatch_chromium.org, jchaffraix+rendering, blink-reviews, gyuyoung2, pdr+svgwatchlist_chromium.org, jfernandez, zoltan1, eae+blinkwatch, blink-reviews-layout_chromium.org, feature-media-reviews_chromium.org, mlamouri+watch-blink_chromium.org, svillar, pdr+renderingwatchlist_chromium.org, leviw+renderwatch, f(malita), Stephen Chennney
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Don't establish LayoutState for LayoutTableRow objects. Table rows are not the containing block of anything. The real containing block of a table cell is their table section, not the table row. With this change, we no longer need to pass the object's location to LayoutState(). Just call locationOffset() on the object in the constructor instead, rather than doing it at all call sites. Committed: https://crrev.com/4f0ed16557aa042e6bb7cf0ea54640bb469371ba Cr-Commit-Position: refs/heads/master@{#428190}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -23 lines) Patch
M third_party/WebKit/Source/core/layout/LayoutBlock.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp View 1 chunk +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutDeprecatedFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutFlexibleBox.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutGrid.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutMedia.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.h View 1 chunk +0 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutState.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTable.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableRow.cpp View 1 chunk +1 line, -4 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutTableSection.cpp View 3 chunks +4 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/layout/svg/LayoutSVGText.cpp View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
mstensho (USE GERRIT)
4 years, 1 month ago (2016-10-27 20:54:13 UTC) #4
eae
LGTM
4 years, 1 month ago (2016-10-27 22:01:41 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458823002/1
4 years, 1 month ago (2016-10-27 22:20:03 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 23:09:30 UTC) #10
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 23:13:20 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/4f0ed16557aa042e6bb7cf0ea54640bb469371ba
Cr-Commit-Position: refs/heads/master@{#428190}

Powered by Google App Engine
This is Rietveld 408576698