Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1184)

Unified Diff: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp

Issue 2458823002: Don't establish LayoutState for LayoutTableRow objects. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
diff --git a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
index 533a6fa87a8cd31ebcd23397eda10ee2e811f565..48612f65b6bfb2ac0c6ff3a2e7b15a7409facd76 100644
--- a/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
+++ b/third_party/WebKit/Source/core/layout/LayoutTableSection.cpp
@@ -838,9 +838,8 @@ int LayoutTableSection::calcRowLogicalHeight() {
LayoutTableCell* cell;
// We may have to forcefully lay out cells here, in which case we need a
- // layout state. Technically, we should also push state for the row, but since
- // rows don't push a coordinate transform, that's not necessary.
- LayoutState state(*this, locationOffset());
+ // layout state.
+ LayoutState state(*this);
m_rowPos.resize(m_grid.size() + 1);
@@ -960,7 +959,7 @@ void LayoutTableSection::layout() {
// it now ensures we have a stable-enough structure.
m_grid.shrinkToFit();
- LayoutState state(*this, locationOffset());
+ LayoutState state(*this);
const Vector<int>& columnPos = table()->effectiveColumnPositions();
LayoutUnit rowLogicalTop;
@@ -1137,7 +1136,7 @@ void LayoutTableSection::layoutRows() {
int vspacing = table()->vBorderSpacing();
unsigned nEffCols = table()->numEffectiveColumns();
- LayoutState state(*this, locationOffset());
+ LayoutState state(*this);
// Set the rows' location and size.
for (unsigned r = 0; r < totalRows; r++) {
« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutTableRow.cpp ('k') | third_party/WebKit/Source/core/layout/LayoutVTTCue.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698