Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(609)

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlock.cpp

Issue 2458823002: Don't establish LayoutState for LayoutTableRow objects. (Closed)
Patch Set: Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * (C) 1999 Antti Koivisto (koivisto@kde.org) 3 * (C) 1999 Antti Koivisto (koivisto@kde.org)
4 * (C) 2007 David Smith (catfish.man@gmail.com) 4 * (C) 2007 David Smith (catfish.man@gmail.com)
5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc. 5 * Copyright (C) 2003, 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2011 Apple Inc.
6 * All rights reserved. 6 * All rights reserved.
7 * Copyright (C) Research In Motion Limited 2010. All rights reserved. 7 * Copyright (C) Research In Motion Limited 2010. All rights reserved.
8 * 8 *
9 * This library is free software; you can redistribute it and/or 9 * This library is free software; you can redistribute it and/or
10 * modify it under the terms of the GNU Library General Public 10 * modify it under the terms of the GNU Library General Public
(...skipping 594 matching lines...) Expand 10 before | Expand all | Expand 10 after
605 if (normalChildNeedsLayout() || selfNeedsLayout()) 605 if (normalChildNeedsLayout() || selfNeedsLayout())
606 return false; 606 return false;
607 607
608 // Check that we actually need to do a simplified layout. 608 // Check that we actually need to do a simplified layout.
609 if (!posChildNeedsLayout() && 609 if (!posChildNeedsLayout() &&
610 !(needsSimplifiedNormalFlowLayout() || needsPositionedMovementLayout())) 610 !(needsSimplifiedNormalFlowLayout() || needsPositionedMovementLayout()))
611 return false; 611 return false;
612 612
613 { 613 {
614 // LayoutState needs this deliberate scope to pop before paint invalidation. 614 // LayoutState needs this deliberate scope to pop before paint invalidation.
615 LayoutState state(*this, locationOffset()); 615 LayoutState state(*this);
616 616
617 if (needsPositionedMovementLayout() && 617 if (needsPositionedMovementLayout() &&
618 !tryLayoutDoingPositionedMovementOnly()) 618 !tryLayoutDoingPositionedMovementOnly())
619 return false; 619 return false;
620 620
621 if (LayoutFlowThread* flowThread = flowThreadContainingBlock()) { 621 if (LayoutFlowThread* flowThread = flowThreadContainingBlock()) {
622 if (!flowThread->canSkipLayout(*this)) 622 if (!flowThread->canSkipLayout(*this))
623 return false; 623 return false;
624 } 624 }
625 625
(...skipping 1587 matching lines...) Expand 10 before | Expand all | Expand 10 after
2213 } 2213 }
2214 2214
2215 return availableHeight; 2215 return availableHeight;
2216 } 2216 }
2217 2217
2218 bool LayoutBlock::hasDefiniteLogicalHeight() const { 2218 bool LayoutBlock::hasDefiniteLogicalHeight() const {
2219 return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1); 2219 return availableLogicalHeightForPercentageComputation() != LayoutUnit(-1);
2220 } 2220 }
2221 2221
2222 } // namespace blink 2222 } // namespace blink
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/core/layout/LayoutBlockFlow.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698