Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(267)

Issue 2458723002: Revert of Reduced skslc memory consumption (Closed)

Created:
4 years, 1 month ago by dogben
Modified:
4 years, 1 month ago
Reviewers:
ethannicholas, reed1
CC:
reviews_skia.org
Target Ref:
refs/heads/master
Project:
skia
Visibility:
Public.

Description

Revert of Reduced skslc memory consumption (patchset #3 id:50001 of https://codereview.chromium.org/2442063002/ ) Reason for revert: texelFetch removed, but is used in some shaders. Original issue's description: > Reduced skslc memory consumption > > The big change here is smarter generic type handling which allows us to > keep far fewer entries in the core symboltable. This also comments out > a number of OpenGL builtin functions which Skia does not use and is > unlikely to in the future. > BUG=655673 > GOLD_TRYBOT_URL= https://gold.skia.org/search?issue=2442063002 > > Committed: https://skia.googlesource.com/skia/+/cffaa70896fa5bc6c7bf98abbaafb1a755b49762 TBR=reed@google.com,ethannicholas@google.com # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=655673 Committed: https://skia.googlesource.com/skia/+/56380524d903f27627a75e2e1189463999725008

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+116 lines, -180 lines) Patch
M src/sksl/SkSLContext.h View 3 chunks +9 lines, -11 lines 0 comments Download
M src/sksl/SkSLIRGenerator.cpp View 6 chunks +46 lines, -28 lines 0 comments Download
M src/sksl/SkSLParser.cpp View 1 chunk +3 lines, -12 lines 0 comments Download
M src/sksl/SkSLToken.h View 1 chunk +0 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLFunctionCall.h View 1 chunk +2 lines, -2 lines 0 comments Download
M src/sksl/ir/SkSLFunctionDeclaration.h View 2 chunks +0 lines, -45 lines 0 comments Download
M src/sksl/ir/SkSLType.h View 1 chunk +1 line, -3 lines 0 comments Download
M src/sksl/sksl.include View 13 chunks +54 lines, -71 lines 0 comments Download
M tests/SkSLErrorTest.cpp View 1 chunk +1 line, -6 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
dogben
Created Revert of Reduced skslc memory consumption
4 years, 1 month ago (2016-10-27 16:07:53 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458723002/1
4 years, 1 month ago (2016-10-27 16:08:00 UTC) #3
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 16:08:08 UTC) #5
Message was sent while issue was closed.
Committed patchset #1 (id:1) as
https://skia.googlesource.com/skia/+/56380524d903f27627a75e2e1189463999725008

Powered by Google App Engine
This is Rietveld 408576698