Move debug_devtools to a buildflag_header.

Move debug_devtools to a buildflag_header.

Previously this was in the global features.gni file, and files did an ad-hoc
reference to the debug_devtools config if they needed the define. This is
fragile and will not scale as additional flags are added.

This patch introduces a Blink public features buildflag_header (in the
future I expect we'll also have a Blink-internal one in Source/). The
existing users of debug_devtools are updated to use this.

BUG=

Committed: https://crrev.com/cb4ab75ac5e94b7857b70a9d6f73eefe9db47a7f
Cr-Commit-Position: refs/heads/master@{#429362}

[brettw, 2016-10-27 20:24:30]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 20:25:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:20:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:20:50]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-10-27 22:24:31]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-27 22:25:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 22:30:42]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-27 22:30:43]

Dry run: Try jobs failed on following builders:
  mac_chromium_rel_ng on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[brettw, 2016-10-28 16:50:19]

brettw@chromium.org changed reviewers:
+ pfeldman@chromium.org

[brettw, 2016-10-28 16:50:20]

Merge

[brettw, 2016-10-28 16:50:20]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-28 16:50:40]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-28 18:43:50]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-28 18:43:51]

Dry run: This issue passed the CQ dry run.

[brettw, 2016-10-28 21:07:57]

brettw@chromium.org changed reviewers:
+ pfeldman@chromium.org

[brettw, 2016-10-31 17:04:05]

Merge

[brettw, 2016-10-31 17:04:05]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 17:04:27]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 17:40:04]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 17:40:05]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[brettw, 2016-10-31 21:25:46]

Ping

[brettw, 2016-10-31 21:56:09]

The CQ bit was checked by brettw@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 21:56:53]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 23:20:40]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 23:20:41]

Dry run: This issue passed the CQ dry run.

[dcheng, 2016-11-01 22:34:23]

dcheng@chromium.org changed reviewers:
+ dcheng@chromium.org

[dcheng, 2016-11-01 22:34:24]

LGTM

[brettw, 2016-11-01 22:39:14]

brettw@chromium.org changed reviewers:
+ avi@chromium.org
- pfeldman@chromium.org

[brettw, 2016-11-01 22:39:14]

+Avi for content and chrome (should be straightforward search-and-replace).

[Avi (use Gerrit), 2016-11-02 17:37:59]

On 2016/11/01 22:39:14, brettw (ping on IM after 24h) wrote:
> +Avi for content and chrome (should be straightforward search-and-replace).

To whatever the extent my LGTM is needed you have it.

[brettw, 2016-11-02 17:38:45]

The CQ bit was checked by brettw@chromium.org

[commit-bot: I haz the power, 2016-11-02 17:39:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 19:26:36]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-11-02 19:28:26]

Description was changed from

==========
Move debug_devtools to a buildflag_header.

Previously this was in the global features.gni file, and files did an ad-hoc
reference to the debug_devtools config if they needed the define. This is
fragile and will not scale as additional flags are added.

This patch introduces a Blink public features buildflag_header (in the
future I expect we'll also have a Blink-internal one in Source/). The
existing users of debug_devtools are updated to use this.

BUG=
==========

to

==========
Move debug_devtools to a buildflag_header.

Previously this was in the global features.gni file, and files did an ad-hoc
reference to the debug_devtools config if they needed the define. This is
fragile and will not scale as additional flags are added.

This patch introduces a Blink public features buildflag_header (in the
future I expect we'll also have a Blink-internal one in Source/). The
existing users of debug_devtools are updated to use this.

BUG=

Committed: https://crrev.com/cb4ab75ac5e94b7857b70a9d6f73eefe9db47a7f
Cr-Commit-Position: refs/heads/master@{#429362}
==========

[commit-bot: I haz the power, 2016-11-02 19:28:28]

Patchset 3 (id:??) landed as
https://crrev.com/cb4ab75ac5e94b7857b70a9d6f73eefe9db47a7f
Cr-Commit-Position: refs/heads/master@{#429362}