Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(183)

Unified Diff: chrome/browser/ui/webui/devtools_ui.cc

Issue 2458573004: Move debug_devtools to a buildflag_header. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/ui/webui/devtools_ui.cc
diff --git a/chrome/browser/ui/webui/devtools_ui.cc b/chrome/browser/ui/webui/devtools_ui.cc
index ed6c43c7640d5dbe0c9164b805ad1e05cb30c49d..f0e7120492359014a1ffafd5bd52730f0f1bdb4f 100644
--- a/chrome/browser/ui/webui/devtools_ui.cc
+++ b/chrome/browser/ui/webui/devtools_ui.cc
@@ -22,6 +22,7 @@
#include "net/url_request/url_fetcher.h"
#include "net/url_request/url_fetcher_delegate.h"
#include "net/url_request/url_request_context_getter.h"
+#include "third_party/WebKit/public/public_features.h"
using content::BrowserThread;
using content::WebContents;
@@ -39,7 +40,7 @@ const char kRemoteFrontendBase[] =
const char kRemoteFrontendPath[] = "serve_file";
const char kHttpNotFound[] = "HTTP/1.1 404 Not Found\n\n";
-#if defined(DEBUG_DEVTOOLS)
+#if BUILDFLAG(DEBUG_DEVTOOLS)
// Local frontend url provided by InspectUI.
const char kFallbackFrontendURL[] =
"chrome-devtools://devtools/bundled/inspector.html";
@@ -47,7 +48,7 @@ const char kFallbackFrontendURL[] =
// URL causing the DevTools window to display a plain text warning.
const char kFallbackFrontendURL[] =
"data:text/plain,Cannot load DevTools frontend from an untrusted origin";
-#endif // defined(DEBUG_DEVTOOLS)
+#endif // BUILDFLAG(DEBUG_DEVTOOLS)
GURL SanitizeFrontendURL(
const GURL& url,
« no previous file with comments | « chrome/browser/ui/BUILD.gn ('k') | chrome/test/BUILD.gn » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698