Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1479)

Unified Diff: chrome/browser/devtools/device/port_forwarding_controller.cc

Issue 2458573004: Move debug_devtools to a buildflag_header. (Closed)
Patch Set: Merge Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/devtools/BUILD.gn ('k') | chrome/browser/devtools/device/tcp_device_provider.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/devtools/device/port_forwarding_controller.cc
diff --git a/chrome/browser/devtools/device/port_forwarding_controller.cc b/chrome/browser/devtools/device/port_forwarding_controller.cc
index 315aa5858e2b82e337cc88408d7c2392d54d3565..e21121220284a1fb3c046fe0d0c0f799161ac76a 100644
--- a/chrome/browser/devtools/device/port_forwarding_controller.cc
+++ b/chrome/browser/devtools/device/port_forwarding_controller.cc
@@ -31,6 +31,7 @@
#include "net/log/net_log_source.h"
#include "net/log/net_log_with_source.h"
#include "net/socket/tcp_client_socket.h"
+#include "third_party/WebKit/public/public_features.h"
using content::BrowserThread;
@@ -316,9 +317,9 @@ void PortForwardingController::Connection::SendCommand(
pending_responses_[id] =
base::Bind(&Connection::ProcessBindResponse,
base::Unretained(this), port);
-#if defined(DEBUG_DEVTOOLS)
+#if BUILDFLAG(DEBUG_DEVTOOLS)
port_status_[port] = kStatusConnecting;
-#endif // defined(DEBUG_DEVTOOLS)
+#endif // BUILDFLAG(DEBUG_DEVTOOLS)
} else {
PortStatusMap::iterator it = port_status_.find(port);
if (it != port_status_.end() && it->second == kStatusError) {
@@ -330,9 +331,9 @@ void PortForwardingController::Connection::SendCommand(
pending_responses_[id] =
base::Bind(&Connection::ProcessUnbindResponse,
base::Unretained(this), port);
-#if defined(DEBUG_DEVTOOLS)
+#if BUILDFLAG(DEBUG_DEVTOOLS)
port_status_[port] = kStatusDisconnecting;
-#endif // defined(DEBUG_DEVTOOLS)
+#endif // BUILDFLAG(DEBUG_DEVTOOLS)
}
web_socket_->SendFrame(
« no previous file with comments | « chrome/browser/devtools/BUILD.gn ('k') | chrome/browser/devtools/device/tcp_device_provider.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698