Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(111)

Issue 2458333002: Add popcnt support for pnacl (Closed)

Created:
4 years, 1 month ago by Isaac (away)
Modified:
4 years, 1 month ago
CC:
chromium-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add popcnt support for pnacl Detect popcount from cpuid and add feature flag in pnacl. BUG=660673 Committed: https://crrev.com/b7d2f408e8d9b4dd4443222e61b0bc71932a4ab4 Cr-Commit-Position: refs/heads/master@{#428632}

Patch Set 1 #

Patch Set 2 : fix comment #

Patch Set 3 : style cleanup #

Patch Set 4 : fix initializer #

Total comments: 1

Patch Set 5 : Add popcnt test for clang #

Unified diffs Side-by-side diffs Delta from patch set Stats (+18 lines, -1 line) Patch
M base/cpu.h View 2 chunks +2 lines, -0 lines 0 comments Download
M base/cpu.cc View 1 2 3 2 chunks +3 lines, -0 lines 0 comments Download
M base/cpu_unittest.cc View 1 2 3 4 2 chunks +10 lines, -0 lines 0 comments Download
M components/nacl/renderer/platform_info.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 28 (19 generated)
Isaac (away)
4 years, 1 month ago (2016-10-30 01:40:06 UTC) #4
Mark Seaborn
LGTM
4 years, 1 month ago (2016-10-30 02:35:16 UTC) #7
Isaac (away)
+mark for base owners (thakis away)
4 years, 1 month ago (2016-10-30 03:10:17 UTC) #11
Mark Mentovai
https://codereview.chromium.org/2458333002/diff/60001/base/cpu_unittest.cc File base/cpu_unittest.cc (right): https://codereview.chromium.org/2458333002/diff/60001/base/cpu_unittest.cc#newcode30 base/cpu_unittest.cc:30: #if defined(COMPILER_GCC) Test popcnt up here in the gcc/clang ...
4 years, 1 month ago (2016-10-30 15:37:55 UTC) #16
Isaac (away)
On 2016/10/30 15:37:55, Mark Mentovai wrote: > Test popcnt up here in the gcc/clang branch. ...
4 years, 1 month ago (2016-10-30 16:23:11 UTC) #19
Mark Mentovai
LGTM
4 years, 1 month ago (2016-10-30 19:44:15 UTC) #22
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2458333002/80001
4 years, 1 month ago (2016-10-30 20:42:23 UTC) #25
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-30 20:47:23 UTC) #26
commit-bot: I haz the power
4 years, 1 month ago (2016-10-30 20:49:40 UTC) #28
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/b7d2f408e8d9b4dd4443222e61b0bc71932a4ab4
Cr-Commit-Position: refs/heads/master@{#428632}

Powered by Google App Engine
This is Rietveld 408576698