[LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace.

[LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace.

BUG=635619
Committed: https://crrev.com/08d3a096f20ce0196474108dc8a28ceddc3203c3
Cr-Commit-Position: refs/heads/master@{#428757}

[ikilpatrick, 2016-10-29 00:08:44]

ikilpatrick@chromium.org changed reviewers:
+ cbiesinger@chromium.org, glebl@chromium.org

[Gleb Lanbin, 2016-10-31 16:33:56]

lgtm

https://codereview.chromium.org/2458253002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2458253002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:23:
new NGPhysicalConstraintSpace(
may be it's time to introduce a builder for NGPhysicalConstraintSpace ?

[Gleb Lanbin, 2016-10-31 16:33:59]

lgtm

[ikilpatrick, 2016-10-31 17:00:03]

https://codereview.chromium.org/2458253002/diff/1/third_party/WebKit/Source/c...
File third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc
(right):

https://codereview.chromium.org/2458253002/diff/1/third_party/WebKit/Source/c...
third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc:23:
new NGPhysicalConstraintSpace(
On 2016/10/31 16:33:56, glebl wrote:
> may be it's time to introduce a builder for NGPhysicalConstraintSpace ? 

Switched to builder here :)

[ikilpatrick, 2016-10-31 17:00:23]

The CQ bit was checked by ikilpatrick@chromium.org

[ikilpatrick, 2016-10-31 17:00:23]

The patchset sent to the CQ was uploaded after l-g-t-m from glebl@chromium.org
Link to the patchset: https://codereview.chromium.org/2458253002/#ps20001
(title: "switch to builder.")

[commit-bot: I haz the power, 2016-10-31 17:00:40]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 18:25:30]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-10-31 18:47:26]

Description was changed from

==========
[LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace.

BUG=635619
==========

to

==========
[LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace.

BUG=635619

Committed: https://crrev.com/08d3a096f20ce0196474108dc8a28ceddc3203c3
Cr-Commit-Position: refs/heads/master@{#428757}
==========

[commit-bot: I haz the power, 2016-10-31 18:47:27]

Patchset 2 (id:??) landed as
https://crrev.com/08d3a096f20ce0196474108dc8a28ceddc3203c3
Cr-Commit-Position: refs/heads/master@{#428757}

[kjellander_chromium, 2016-11-01 09:33:49]

A revert of this CL (patchset #2 id:20001) has been created in
https://codereview.chromium.org/2470733002/ by kjellander@chromium.org.

The reason for reverting is: Speculative revert due to failures in webkit_tests
on WebKit Win7 (dbg) starting with
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%...
(this was the only WebKit CL in the blamelist)..