[LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace.

third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/ng/ng_block_layout_algorithm.h"
 
 #include "core/layout/ng/ng_box.h"
 #include "core/layout/ng/ng_constraint_space.h"
 #include "core/layout/ng/ng_physical_fragment.h"
 #include "core/layout/ng/ng_length_utils.h"
 #include "core/layout/ng/ng_units.h"
 #include "core/style/ComputedStyle.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 namespace {
 
 NGConstraintSpace* ConstructConstraintSpace(NGWritingMode writing_mode,
                                             NGDirection direction,
                                             NGPhysicalSize size) {
-  return new NGConstraintSpace(writing_mode, direction,
-                               new NGPhysicalConstraintSpace(size));
+  return new NGConstraintSpace(
+      writing_mode, direction,
+      new NGPhysicalConstraintSpace(

[Gleb Lanbin, 2016/10/31 16:33:56]

may be it's time to introduce a builder for NGPhysicalConstraintSpace ? 

[ikilpatrick, 2016/10/31 17:00:03]

Switched to builder here :)

+          size, /* fixed_width */ false, /* fixed_height */ false,
+          /* width_direction_triggers_scrollbar */ false,
+          /* height_direction_triggers_scrollbar */ false, FragmentNone,
+          FragmentColumn, /* is_new_fc */ false));
 }
 
 class NGBlockLayoutAlgorithmTest : public ::testing::Test {
  protected:
   void SetUp() override { style_ = ComputedStyle::create(); }
 
   NGPhysicalFragment* RunBlockLayoutAlgorithm(NGConstraintSpace* space,
                                               NGBox* first_child) {
     NGBlockLayoutAlgorithm algorithm(style_, first_child, space);
     NGPhysicalFragment* frag;
@@ skipping 626 matching lines @@
   EXPECT_EQ(0, child2->TopOffset());
   EXPECT_EQ(kParentSize - kDiv2Size, child2->LeftOffset());
 
   // DIV3
   const NGPhysicalFragmentBase* child3 = frag->Children()[2];
   EXPECT_EQ(kDiv2Size, child3->TopOffset());
   EXPECT_EQ(kDiv3LeftMargin, child3->LeftOffset());
 }
 }  // namespace
 }  // namespace blink