Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(244)

Issue 2470733002: Revert of [LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace. (Closed)

Created:
4 years, 1 month ago by kjellander_chromium
Modified:
4 years, 1 month ago
CC:
chromium-reviews, cbiesinger, ojan+watch_chromium.org, szager+layoutwatch_chromium.org, glebl+reviews_chromium.org, atotic+reviews_chromium.org, blink-reviews-layout_chromium.org, pdr+renderingwatchlist_chromium.org, eae+blinkwatch, leviw+renderwatch, zoltan1, jchaffraix+rendering, blink-reviews
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of [LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace. (patchset #2 id:20001 of https://codereview.chromium.org/2458253002/ ) Reason for revert: Speculative revert due to failures in webkit_tests on WebKit Win7 (dbg) starting with https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%29/builds/7940 (this was the only WebKit CL in the blamelist). Original issue's description: > [LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace. > > BUG=635619 > > Committed: https://crrev.com/08d3a096f20ce0196474108dc8a28ceddc3203c3 > Cr-Commit-Position: refs/heads/master@{#428757} TBR=glebl@chromium.org,cbiesinger@chromium.org,ikilpatrick@chromium.org # Skipping CQ checks because original CL landed less than 1 days ago. NOPRESUBMIT=true NOTREECHECKS=true NOTRY=true BUG=635619 Committed: https://crrev.com/0ea81d7d3ea571b173fb462f2b0eeed4144000a0 Cr-Commit-Position: refs/heads/master@{#428975}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+84 lines, -74 lines) Patch
M third_party/WebKit/Source/core/layout/ng/ng_block_layout_algorithm_test.cc View 15 chunks +22 lines, -25 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc View 7 chunks +41 lines, -49 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.h View 1 chunk +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/layout/ng/ng_physical_constraint_space.cc View 1 chunk +18 lines, -0 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
kjellander_chromium
Created Revert of [LayoutNG] Remove simple constructors from NGPhysicalConstraintSpace.
4 years, 1 month ago (2016-11-01 09:33:50 UTC) #2
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470733002/1
4 years, 1 month ago (2016-11-01 09:34:00 UTC) #3
commit-bot: I haz the power
Failed to apply patch for third_party/WebKit/Source/core/layout/ng/ng_constraint_space_test.cc: While running git apply --index -3 -p1; error: patch ...
4 years, 1 month ago (2016-11-01 09:34:43 UTC) #5
kjellander_chromium
Retrying after reverting conflicting newer CL in https://codereview.chromium.org/2467803002/
4 years, 1 month ago (2016-11-01 10:46:21 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2470733002/1
4 years, 1 month ago (2016-11-01 10:46:44 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-11-01 10:48:18 UTC) #10
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/0ea81d7d3ea571b173fb462f2b0eeed4144000a0 Cr-Commit-Position: refs/heads/master@{#428975}
4 years, 1 month ago (2016-11-01 10:51:14 UTC) #12
kjellander_chromium
4 years, 1 month ago (2016-11-01 14:24:12 UTC) #13
Message was sent while issue was closed.
A revert of this CL (patchset #1 id:1) has been created in
https://codereview.chromium.org/2466913002/ by kjellander@chromium.org.

The reason for reverting is: Relanding as newer builds showed the same failures:
https://build.chromium.org/p/chromium.webkit/builders/WebKit%20Win7%20%28dbg%....

Powered by Google App Engine
This is Rietveld 408576698