Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1445)

Issues Search
    My Issues | Starred     Open | Closed | All

Unified Diff: xfa/fxfa/app/xfa_fftextedit.cpp

Issue 2457673003: Fix some FX_BOOL / int noise in fxfa (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« xfa/fxfa/app/xfa_ffdocview.cpp ('K') | « xfa/fxfa/app/xfa_ffdocview.cpp ('k') | xfa/fxfa/app/xfa_ffwidgethandler.cpp » ('j') | xfa/fxfa/app/xfa_ffwidgethandler.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: xfa/fxfa/app/xfa_fftextedit.cpp
diff --git a/xfa/fxfa/app/xfa_fftextedit.cpp b/xfa/fxfa/app/xfa_fftextedit.cpp
index 9f3c94ba7e2974cb82e327f0079b17a45650eea0..eb2a55898dae2d1f24976d7d231944c323428dd5 100644
--- a/xfa/fxfa/app/xfa_fftextedit.cpp
+++ b/xfa/fxfa/app/xfa_fftextedit.cpp
@@ -325,7 +325,7 @@ FX_BOOL CXFA_FFTextEdit::Paste(const CFX_WideString& wsPaste) {
}
FX_BOOL CXFA_FFTextEdit::SelectAll() {
int32_t nCount = ((CFWL_Edit*)m_pNormalWidget)->GetTextLength();
- return ((CFWL_Edit*)m_pNormalWidget)->AddSelRange(0, nCount);
+ return ((CFWL_Edit*)m_pNormalWidget)->AddSelRange(0, nCount) >= 0;
Tom Sepez 2016/10/27 21:04:49 uses -1 as an error code at https://cs.chromium.or
}
FX_BOOL CXFA_FFTextEdit::Delete() {
return ((CFWL_Edit*)m_pNormalWidget)->Delete();
« xfa/fxfa/app/xfa_ffdocview.cpp ('K') | « xfa/fxfa/app/xfa_ffdocview.cpp ('k') | xfa/fxfa/app/xfa_ffwidgethandler.cpp » ('j') | xfa/fxfa/app/xfa_ffwidgethandler.cpp » ('J')

Powered by Google App Engine
This is Rietveld 408576698