[MD Settings][Sync Settings] Updates sync status messages

[MD Settings][Sync Settings] Updates sync status messages

BUG=612595
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1
Cr-Commit-Position: refs/heads/master@{#430023}

[Moe, 2016-10-26 18:05:25]

Description was changed from

==========
[MD Settings][Sync Settings] Updates sync status messages

BUG=612595
==========

to

==========
[MD Settings][Sync Settings] Updates sync status messages

BUG=612595
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

[Moe, 2016-10-26 18:06:11]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-26 18:06:52]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Moe, 2016-10-26 18:07:18]

mahmadi@chromium.org changed reviewers:
+ tommycli@chromium.org

[Moe, 2016-10-26 18:07:18]

Tommy, Please review this CL. I'll add the appropriate owners after your
feedback.

[commit-bot: I haz the power, 2016-10-26 18:23:03]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 18:23:04]

Dry run: Try jobs failed on following builders:
  ios-simulator on master.tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/ios-simulator/bui...)

[tommycli, 2016-10-28 21:21:09]

lgtm except below:

https://codereview.chromium.org/2457483002/diff/1/chrome/app/chromium_strings...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/app/chromium_strings...
chrome/app/chromium_strings.grd:1156: <message
name="IDS_SYNC_UPGRADE_CLIENT_LINK_LABEL" desc="The text to display on in the
hyperlink indicating the user needs to upgrade the client to use sync.">
nit: message description has grammar error. Maybe can also simplify desc.

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11718: +        <message
name="IDS_SYNC_STATUS_UNRECOVERABLE_ERROR_CROS" desc="Message shown on the
personal options page when there is an unrecoverable error in Chrome OS as well
as for managed accounts.">
maybe - IDS_SYNC_STATUS_UNRECOVERABLE_ERROR_NEED_SIGNOUT ? Since now cros
specific

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11721: +        <message
name="IDS_SYNC_PASSWORD_SYNC_ATTENTION" desc="Message indicating password sync
needs attention.">
nit: maybe IDS_SYNC_STATUS_NEEDS_PASSWORD?

also in description: maybe "Message indicating sync password needs attention." ?
or "Message indicating user must re-enter their sync password"?

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11724: +        <message
name="IDS_SYNC_PASSWORD_LINK_LABEL" desc="The text to display on in the
hyperlink indicating indicating password sync needs attention.">
nit: in description, "indicating" is repated twice

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:162: <button
class="subpage-arrow" is="paper-icon-button-light"
Can we do this in pure CSS ? i.e.

#sync-status:not[actionable] .subpage-arrow {
  display: none;
}

?

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.js:286: }
I assume all these behaviors are desired / specified by the interaction
designer?

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_browser_proxy.js
(right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_browser_proxy.js:35:
settings.StatusAction = {
Add a note that this must be kept in sync with the values in people_handler

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/signin/signi...
File chrome/browser/signin/signin_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/signin/signi...
chrome/browser/signin/signin_ui_util.cc:7: #include <string>
nit: not needed if included in .h file'

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util.cc:127: if
(browser_sync::ShouldShowActionOnUI(status.sync_protocol_error)) {
Hmm this looks odd to read, since ShouldShowActionOnUI returns false for the
REAUTHENTICATE case?

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util.cc:133: #if !defined(OS_CHROMEOS)
this can be an #if, #else, #endif

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
File chrome/browser/sync/sync_ui_util_unittest.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util_unittest.cc:495: }
nice tests

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/people_handler.cc:158: return
std::string("reauthenticate");
nit: are you sure it's necessary to wrap all these return values in std::string
constructor?

[Moe, 2016-11-01 19:44:01]

https://codereview.chromium.org/2457483002/diff/1/chrome/app/chromium_strings...
File chrome/app/chromium_strings.grd (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/app/chromium_strings...
chrome/app/chromium_strings.grd:1156: <message
name="IDS_SYNC_UPGRADE_CLIENT_LINK_LABEL" desc="The text to display on in the
hyperlink indicating the user needs to upgrade the client to use sync.">
On 2016/10/28 21:21:09, tommycli wrote:
> nit: message description has grammar error. Maybe can also simplify desc.

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
File chrome/app/generated_resources.grd (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11718: +        <message
name="IDS_SYNC_STATUS_UNRECOVERABLE_ERROR_CROS" desc="Message shown on the
personal options page when there is an unrecoverable error in Chrome OS as well
as for managed accounts.">
On 2016/10/28 21:21:09, tommycli wrote:
> maybe - IDS_SYNC_STATUS_UNRECOVERABLE_ERROR_NEED_SIGNOUT ? Since now cros
> specific

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11721: +        <message
name="IDS_SYNC_PASSWORD_SYNC_ATTENTION" desc="Message indicating password sync
needs attention.">
On 2016/10/28 21:21:09, tommycli wrote:
> nit: maybe IDS_SYNC_STATUS_NEEDS_PASSWORD?
> 
> also in description: maybe "Message indicating sync password needs attention."
?
> or "Message indicating user must re-enter their sync password"?

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/app/generated_resour...
chrome/app/generated_resources.grd:11724: +        <message
name="IDS_SYNC_PASSWORD_LINK_LABEL" desc="The text to display on in the
hyperlink indicating indicating password sync needs attention.">
On 2016/10/28 21:21:09, tommycli wrote:
> nit: in description, "indicating" is repated twice

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.html (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.html:162: <button
class="subpage-arrow" is="paper-icon-button-light"
On 2016/10/28 21:21:09, tommycli wrote:
> Can we do this in pure CSS ? i.e.
> 
> #sync-status:not[actionable] .subpage-arrow {
>   display: none;
> }
> 
> ?

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/people_page.js (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/people_page.js:286: }
On 2016/10/28 21:21:09, tommycli wrote:
> I assume all these behaviors are desired / specified by the interaction
> designer?

I believe so. I need to double check the 'upgrade' action though.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
File chrome/browser/resources/settings/people_page/sync_browser_proxy.js
(right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/resources/se...
chrome/browser/resources/settings/people_page/sync_browser_proxy.js:35:
settings.StatusAction = {
On 2016/10/28 21:21:09, tommycli wrote:
> Add a note that this must be kept in sync with the values in people_handler

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/signin/signi...
File chrome/browser/signin/signin_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/signin/signi...
chrome/browser/signin/signin_ui_util.cc:7: #include <string>
On 2016/10/28 21:21:09, tommycli wrote:
> nit: not needed if included in .h file'

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util.cc:127: if
(browser_sync::ShouldShowActionOnUI(status.sync_protocol_error)) {
On 2016/10/28 21:21:09, tommycli wrote:
> Hmm this looks odd to read, since ShouldShowActionOnUI returns false for the
> REAUTHENTICATE case?

Here's my interpretation:
in the new design, the REAUTHENTICATE action should be associated with the
generic unrecoverable error message. If the unrecoverable error, however, comes
with a specific action, the message for that action should be displayed.

the call to browser_sync::ShouldShowActionOnUI was redundant imo. So I removed
it. The code should read better now when the comment is taken into
consideration.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/sync/sync_ui...
chrome/browser/sync/sync_ui_util.cc:133: #if !defined(OS_CHROMEOS)
On 2016/10/28 21:21:09, tommycli wrote:
> this can be an #if, #else, #endif

Done.

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/ui/webui/set...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2457483002/diff/1/chrome/browser/ui/webui/set...
chrome/browser/ui/webui/settings/people_handler.cc:158: return
std::string("reauthenticate");
On 2016/10/28 21:21:09, tommycli wrote:
> nit: are you sure it's necessary to wrap all these return values in
std::string
> constructor?

Done.

[Moe, 2016-11-01 19:50:58]

mahmadi@chromium.org changed reviewers:
+ dbeam@chromium.org, maxbogue@chromium.org, rogerta@chromium.org

[Moe, 2016-11-01 19:50:59]

Hi Please review this CL.

maxbogue@ sync 
rogerta@ c/b/signin
dbeam@ c/b/u/webui/options

[Roger Tawa OOO till Jul 10th, 2016-11-02 17:33:41]

c/b/signin lgtm, one question below.

https://codereview.chromium.org/2457483002/diff/40001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/40001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util.cc:114: break;
Wouldn't it be better to keep the NOTREACHED() or maybe set the output args to
some default values?

[Moe, 2016-11-02 18:46:00]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[Moe, 2016-11-02 18:46:33]

https://codereview.chromium.org/2457483002/diff/40001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/40001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util.cc:114: break;
On 2016/11/02 17:33:41, Roger Tawa wrote:
> Wouldn't it be better to keep the NOTREACHED() or maybe set the output args to
> some default values?

after removing browser_sync::ShouldShowActionOnUI() the default case is
reachable. But I agree with you. It's best to clear() the status_label in the
default case b/c we expect the output arg to be an empty string.

[commit-bot: I haz the power, 2016-11-02 18:46:43]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 19:55:56]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 19:55:56]

Dry run: This issue passed the CQ dry run.

[maxbogue, 2016-11-03 23:08:50]

lgtm w/ some comments

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util.cc:496: ActionType
actionType(sync_ui_util::NO_ACTION);
ActionType action_type = NO_ACTION;

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_ui_util_unittest.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:354: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
sync_ui_util::ActionType action_type = sync_ui_util::NO_ACTION;

Also, check the output of this variable after GetStatusLabels?

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:393: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
Please use = here as well, and check the output of this variable after the call.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:429: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
Please use =

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:435: EXPECT_EQ(action_type,
sync_ui_util::REAUTHENTICATE);
Expected value should go first.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:448: EXPECT_EQ(action_type,
sync_ui_util::UPGRADE_CLIENT);
Expected value should go first.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:471: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
= here as well

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:477: EXPECT_EQ(action_type,
sync_ui_util::UPGRADE_CLIENT);
Expected value first.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:491: EXPECT_EQ(action_type,
sync_ui_util::NO_ACTION);
Expected value first.

[Dan Beam, 2016-11-04 17:32:00]

lgtm, glad tommycli@ also looked (was going to forward you to him, but he
already LG'd, so i'm fine with it)

thanks again for the help!

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:1549:
sync_ui_util::ActionType actionType = sync_ui_util::NO_ACTION;
nit: action_type

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/people_handler.cc:155: std::string
getSyncErrorAction(sync_ui_util::ActionType actionType) {
GetSyncErrorAction
^

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/people_handler.cc:747: sync_ui_util::ActionType
actionType(sync_ui_util::NO_ACTION);
action_type

[Moe, 2016-11-04 19:58:23]

The CQ bit was checked by mahmadi@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-04 19:59:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 21:23:02]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-04 21:23:03]

Dry run: This issue passed the CQ dry run.

[Moe, 2016-11-04 21:34:09]

Thank you all.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_ui_util.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util.cc:496: ActionType
actionType(sync_ui_util::NO_ACTION);
On 2016/11/03 23:08:49, maxbogue wrote:
> ActionType action_type = NO_ACTION;

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
File chrome/browser/sync/sync_ui_util_unittest.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:354: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
On 2016/11/03 23:08:50, maxbogue wrote:
> sync_ui_util::ActionType action_type = sync_ui_util::NO_ACTION;
> 
> Also, check the output of this variable after GetStatusLabels?

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:393: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
On 2016/11/03 23:08:49, maxbogue wrote:
> Please use = here as well, and check the output of this variable after the
call.

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:429: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
On 2016/11/03 23:08:50, maxbogue wrote:
> Please use =

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:435: EXPECT_EQ(action_type,
sync_ui_util::REAUTHENTICATE);
On 2016/11/03 23:08:50, maxbogue wrote:
> Expected value should go first.

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:448: EXPECT_EQ(action_type,
sync_ui_util::UPGRADE_CLIENT);
On 2016/11/03 23:08:50, maxbogue wrote:
> Expected value should go first.

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:471: sync_ui_util::ActionType
action_type(sync_ui_util::NO_ACTION);
On 2016/11/03 23:08:50, maxbogue wrote:
> = here as well

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:477: EXPECT_EQ(action_type,
sync_ui_util::UPGRADE_CLIENT);
On 2016/11/03 23:08:50, maxbogue wrote:
> Expected value first.

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/sync/syn...
chrome/browser/sync/sync_ui_util_unittest.cc:491: EXPECT_EQ(action_type,
sync_ui_util::NO_ACTION);
On 2016/11/03 23:08:50, maxbogue wrote:
> Expected value first.

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/options/browser_options_handler.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/options/browser_options_handler.cc:1549:
sync_ui_util::ActionType actionType = sync_ui_util::NO_ACTION;
On 2016/11/04 17:31:59, Dan Beam wrote:
> nit: action_type

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
File chrome/browser/ui/webui/settings/people_handler.cc (right):

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/people_handler.cc:155: std::string
getSyncErrorAction(sync_ui_util::ActionType actionType) {
On 2016/11/04 17:31:59, Dan Beam wrote:
> GetSyncErrorAction
> ^

Done.

https://codereview.chromium.org/2457483002/diff/60001/chrome/browser/ui/webui...
chrome/browser/ui/webui/settings/people_handler.cc:747: sync_ui_util::ActionType
actionType(sync_ui_util::NO_ACTION);
On 2016/11/04 17:31:59, Dan Beam wrote:
> action_type

Done.

[Moe, 2016-11-04 21:34:15]

The CQ bit was checked by mahmadi@chromium.org

[Moe, 2016-11-04 21:34:16]

The patchset sent to the CQ was uploaded after l-g-t-m from
tommycli@chromium.org, rogerta@chromium.org, dbeam@chromium.org,
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2457483002/#ps80001
(title: "Addressed maxbogue's and dbeam's comments")

[commit-bot: I haz the power, 2016-11-04 21:35:23]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-04 21:41:31]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-04 21:42:56]

Description was changed from

==========
[MD Settings][Sync Settings] Updates sync status messages

BUG=612595
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation
==========

to

==========
[MD Settings][Sync Settings] Updates sync status messages

BUG=612595
CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:closure_compilation

Committed: https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1
Cr-Commit-Position: refs/heads/master@{#430023}
==========

[commit-bot: I haz the power, 2016-11-04 21:42:58]

Patchset 5 (id:??) landed as
https://crrev.com/715a58fd0413dbe6fd2fbccb9d6bc088056de3d1
Cr-Commit-Position: refs/heads/master@{#430023}