Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(109)

Unified Diff: chrome/browser/resources/settings/people_page/people_page.html

Issue 2457483002: [MD Settings][Sync Settings] Updates sync status messages (Closed)
Patch Set: Addressed maxbogue's and dbeam's comments Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/resources/settings/people_page/people_page.html
diff --git a/chrome/browser/resources/settings/people_page/people_page.html b/chrome/browser/resources/settings/people_page/people_page.html
index 2fd9a5dbb2efda232db21bf4e0a18fe6185f081e..6030e4408ce1ad8c69970e08fbae8c82374e97ee 100644
--- a/chrome/browser/resources/settings/people_page/people_page.html
+++ b/chrome/browser/resources/settings/people_page/people_page.html
@@ -55,11 +55,15 @@
--iron-icon-fill-color: var(--google-green-700);
}
- iron-icon[icon='settings:sync-problem'] {
+ #sync-status[actionable] iron-icon[icon='settings:sync-problem'] {
--iron-icon-fill-color: var(--settings-error-color);
}
- .settings-box .sync-error {
+ #sync-status:not([actionable]) .subpage-arrow {
+ display: none;
+ }
+
+ .settings-box[actionable] .sync-error {
color: var(--settings-error-color);
}
@@ -150,18 +154,15 @@
<template is="dom-if"
if="[[isAdvancedSyncSettingsVisible_(syncStatus)]]">
<div class="settings-box two-line" on-tap="onSyncTap_"
- id="customize-sync" actionable$="[[!syncStatus.managed]]">
+ id="sync-status" actionable$="[[isSyncStatusActionable_(
+ syncStatus)]]">
<div class="icon-container">
<iron-icon id="sync-icon" icon$="[[getSyncIcon_(syncStatus)]]">
</iron-icon>
</div>
<div class="middle">
<div>$i18n{sync}</div>
- <div class="secondary" hidden="[[syncStatus.hasError]]">
- [[syncStatus.statusText]]
- </div>
- <div class="secondary sync-error"
- hidden="[[!syncStatus.hasError]]">
+ <div class$="secondary [[getSyncStatusTextClass_(syncStatus)]]">
[[syncStatus.statusText]]
</div>
</div>
@@ -273,7 +274,7 @@
<template is="dom-if" route-path="/syncSetup"
no-search$="[[!isAdvancedSyncSettingsVisible_(syncStatus)]]">
<settings-subpage
- associated-control="[[$$('#customize-sync')]]"
+ associated-control="[[$$('#sync-status')]]"
page-title="$i18n{syncPageTitle}"
no-search$="[[!isAdvancedSyncSettingsVisible_(syncStatus)]]">
<settings-sync-page></settings-sync-page>
« no previous file with comments | « chrome/app/google_chrome_strings.grd ('k') | chrome/browser/resources/settings/people_page/people_page.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698