Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4)

Issue 2457363002: Add offset arguments to readPixels and compressedTex* per WebGL 2.0 spec. (Closed)

Created:
4 years, 1 month ago by Ken Russell (switch to Gerrit)
Modified:
4 years, 1 month ago
CC:
chromium-reviews, blink-reviews, haraken
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add offset arguments to readPixels and compressedTex* per WebGL 2.0 spec. Tested with new tests in https://github.com/KhronosGroup/WebGL/pull/2120 . BUG=639145 CQ_INCLUDE_TRYBOTS=master.tryserver.chromium.linux:linux_optional_gpu_tests_rel;master.tryserver.chromium.mac:mac_optional_gpu_tests_rel;master.tryserver.chromium.win:win_optional_gpu_tests_rel Committed: https://crrev.com/64f33e54a2eb39acb07f9d0d5a7be76313296523 Cr-Commit-Position: refs/heads/master@{#429204}

Patch Set 1 #

Patch Set 2 : Rebased. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+245 lines, -18 lines) Patch
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h View 4 chunks +53 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp View 1 4 chunks +146 lines, -10 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.idl View 1 2 chunks +12 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.h View 1 1 chunk +10 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/webgl/WebGLRenderingContextBase.cpp View 1 3 chunks +24 lines, -4 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
Ken Russell (switch to Gerrit)
PTAL
4 years, 1 month ago (2016-10-30 04:00:35 UTC) #3
Zhenyao Mo
lgtm
4 years, 1 month ago (2016-11-01 17:45:06 UTC) #8
Kai Ninomiya
lgtm
4 years, 1 month ago (2016-11-01 17:54:47 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2457363002/20001
4 years, 1 month ago (2016-11-01 23:56:25 UTC) #12
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 1 month ago (2016-11-02 04:04:41 UTC) #13
commit-bot: I haz the power
4 years, 1 month ago (2016-11-02 04:09:29 UTC) #15
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/64f33e54a2eb39acb07f9d0d5a7be76313296523
Cr-Commit-Position: refs/heads/master@{#429204}

Powered by Google App Engine
This is Rietveld 408576698