Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2457363002: Add offset arguments to readPixels and compressedTex* per WebGL 2.0 spec. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright 2015 The Chromium Authors. All rights reserved. 1 // Copyright 2015 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef WebGL2RenderingContextBase_h 5 #ifndef WebGL2RenderingContextBase_h
6 #define WebGL2RenderingContextBase_h 6 #define WebGL2RenderingContextBase_h
7 7
8 #include "bindings/core/v8/ScriptPromise.h" 8 #include "bindings/core/v8/ScriptPromise.h"
9 #include "bindings/core/v8/TraceWrapperMember.h" 9 #include "bindings/core/v8/TraceWrapperMember.h"
10 #include "modules/webgl/WebGLExtension.h" 10 #include "modules/webgl/WebGLExtension.h"
(...skipping 514 matching lines...) Expand 10 before | Expand all | Expand 10 after
525 525
526 void copyTexSubImage3D(GLenum, 526 void copyTexSubImage3D(GLenum,
527 GLint, 527 GLint,
528 GLint, 528 GLint,
529 GLint, 529 GLint,
530 GLint, 530 GLint,
531 GLint, 531 GLint,
532 GLint, 532 GLint,
533 GLsizei, 533 GLsizei,
534 GLsizei); 534 GLsizei);
535
536 void compressedTexImage2D(GLenum target,
537 GLint level,
538 GLenum internalformat,
539 GLsizei width,
540 GLsizei height,
541 GLint border,
542 DOMArrayBufferView* data,
543 GLuint srcOffset,
544 GLuint srcLengthOverride);
545 void compressedTexSubImage2D(GLenum target,
546 GLint level,
547 GLint xoffset,
548 GLint yoffset,
549 GLsizei width,
550 GLsizei height,
551 GLenum format,
552 DOMArrayBufferView* data,
553 GLuint srcOffset,
554 GLuint srcLengthOverride);
535 void compressedTexImage3D(GLenum, 555 void compressedTexImage3D(GLenum,
536 GLint, 556 GLint,
537 GLenum, 557 GLenum,
538 GLsizei, 558 GLsizei,
539 GLsizei, 559 GLsizei,
540 GLsizei, 560 GLsizei,
541 GLint, 561 GLint,
542 DOMArrayBufferView*); 562 DOMArrayBufferView*,
563 GLuint,
564 GLuint);
543 void compressedTexSubImage3D(GLenum, 565 void compressedTexSubImage3D(GLenum,
544 GLint, 566 GLint,
545 GLint, 567 GLint,
546 GLint, 568 GLint,
547 GLint, 569 GLint,
548 GLsizei, 570 GLsizei,
549 GLsizei, 571 GLsizei,
550 GLsizei, 572 GLsizei,
551 GLenum, 573 GLenum,
552 DOMArrayBufferView*); 574 DOMArrayBufferView*,
575 GLuint,
576 GLuint);
577
578 // Have to re-declare/re-define the following compressedTex{Sub}Image2D
579 // functions from the base class. This is because the above
580 // compressedTex{Sub}Image2D() hide the name from base class.
581 void compressedTexImage2D(GLenum target,
582 GLint level,
583 GLenum internalformat,
584 GLsizei width,
585 GLsizei height,
586 GLint border,
587 DOMArrayBufferView* data);
588 void compressedTexSubImage2D(GLenum target,
589 GLint level,
590 GLint xoffset,
591 GLint yoffset,
592 GLsizei width,
593 GLsizei height,
594 GLenum format,
595 DOMArrayBufferView* data);
553 596
554 /* Programs and shaders */ 597 /* Programs and shaders */
555 GLint getFragDataLocation(WebGLProgram*, const String&); 598 GLint getFragDataLocation(WebGLProgram*, const String&);
556 599
557 /* Uniforms and attributes */ 600 /* Uniforms and attributes */
558 void uniform1ui(const WebGLUniformLocation*, GLuint); 601 void uniform1ui(const WebGLUniformLocation*, GLuint);
559 void uniform2ui(const WebGLUniformLocation*, GLuint, GLuint); 602 void uniform2ui(const WebGLUniformLocation*, GLuint, GLuint);
560 void uniform3ui(const WebGLUniformLocation*, GLuint, GLuint, GLuint); 603 void uniform3ui(const WebGLUniformLocation*, GLuint, GLuint, GLuint);
561 void uniform4ui(const WebGLUniformLocation*, GLuint, GLuint, GLuint, GLuint); 604 void uniform4ui(const WebGLUniformLocation*, GLuint, GLuint, GLuint, GLuint);
562 void uniform1uiv(const WebGLUniformLocation*, const FlexibleUint32ArrayView&); 605 void uniform1uiv(const WebGLUniformLocation*, const FlexibleUint32ArrayView&);
(...skipping 138 matching lines...) Expand 10 before | Expand all | Expand 10 after
701 GLboolean isVertexArray(WebGLVertexArrayObject*); 744 GLboolean isVertexArray(WebGLVertexArrayObject*);
702 void bindVertexArray(WebGLVertexArrayObject*); 745 void bindVertexArray(WebGLVertexArrayObject*);
703 746
704 /* Reading */ 747 /* Reading */
705 void readPixels(GLint x, 748 void readPixels(GLint x,
706 GLint y, 749 GLint y,
707 GLsizei width, 750 GLsizei width,
708 GLsizei height, 751 GLsizei height,
709 GLenum format, 752 GLenum format,
710 GLenum type, 753 GLenum type,
754 DOMArrayBufferView* pixels,
755 GLuint offset);
756 void readPixels(GLint x,
757 GLint y,
758 GLsizei width,
759 GLsizei height,
760 GLenum format,
761 GLenum type,
711 long long offset); 762 long long offset);
712 763
713 /* WebGLRenderingContextBase overrides */ 764 /* WebGLRenderingContextBase overrides */
714 void initializeNewContext() override; 765 void initializeNewContext() override;
715 void bindFramebuffer(GLenum target, WebGLFramebuffer*) override; 766 void bindFramebuffer(GLenum target, WebGLFramebuffer*) override;
716 void deleteFramebuffer(WebGLFramebuffer*) override; 767 void deleteFramebuffer(WebGLFramebuffer*) override;
717 ScriptValue getParameter(ScriptState*, GLenum pname) override; 768 ScriptValue getParameter(ScriptState*, GLenum pname) override;
718 ScriptValue getTexParameter(ScriptState*, 769 ScriptValue getTexParameter(ScriptState*,
719 GLenum target, 770 GLenum target,
720 GLenum pname) override; 771 GLenum pname) override;
(...skipping 185 matching lines...) Expand 10 before | Expand all | Expand 10 after
906 context, 957 context,
907 context->is3d() && 958 context->is3d() &&
908 WebGLRenderingContextBase::getWebGLVersion(context) >= 2, 959 WebGLRenderingContextBase::getWebGLVersion(context) >= 2,
909 context.is3d() && 960 context.is3d() &&
910 WebGLRenderingContextBase::getWebGLVersion(&context) >= 961 WebGLRenderingContextBase::getWebGLVersion(&context) >=
911 2); 962 2);
912 963
913 } // namespace blink 964 } // namespace blink
914 965
915 #endif 966 #endif
OLDNEW
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698