Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(20)

Unified Diff: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h

Issue 2457363002: Add offset arguments to readPixels and compressedTex* per WebGL 2.0 spec. (Closed)
Patch Set: Rebased. Created 4 years, 1 month ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
diff --git a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
index 3983c81696ae9efa2b2ba83162ff5f3a9ecac1d3..e1b2abf87177df8fb02e954a4efdce7f5a2993f2 100644
--- a/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
+++ b/third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.h
@@ -532,6 +532,26 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
GLint,
GLsizei,
GLsizei);
+
+ void compressedTexImage2D(GLenum target,
+ GLint level,
+ GLenum internalformat,
+ GLsizei width,
+ GLsizei height,
+ GLint border,
+ DOMArrayBufferView* data,
+ GLuint srcOffset,
+ GLuint srcLengthOverride);
+ void compressedTexSubImage2D(GLenum target,
+ GLint level,
+ GLint xoffset,
+ GLint yoffset,
+ GLsizei width,
+ GLsizei height,
+ GLenum format,
+ DOMArrayBufferView* data,
+ GLuint srcOffset,
+ GLuint srcLengthOverride);
void compressedTexImage3D(GLenum,
GLint,
GLenum,
@@ -539,7 +559,9 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
GLsizei,
GLsizei,
GLint,
- DOMArrayBufferView*);
+ DOMArrayBufferView*,
+ GLuint,
+ GLuint);
void compressedTexSubImage3D(GLenum,
GLint,
GLint,
@@ -549,7 +571,28 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
GLsizei,
GLsizei,
GLenum,
- DOMArrayBufferView*);
+ DOMArrayBufferView*,
+ GLuint,
+ GLuint);
+
+ // Have to re-declare/re-define the following compressedTex{Sub}Image2D
+ // functions from the base class. This is because the above
+ // compressedTex{Sub}Image2D() hide the name from base class.
+ void compressedTexImage2D(GLenum target,
+ GLint level,
+ GLenum internalformat,
+ GLsizei width,
+ GLsizei height,
+ GLint border,
+ DOMArrayBufferView* data);
+ void compressedTexSubImage2D(GLenum target,
+ GLint level,
+ GLint xoffset,
+ GLint yoffset,
+ GLsizei width,
+ GLsizei height,
+ GLenum format,
+ DOMArrayBufferView* data);
/* Programs and shaders */
GLint getFragDataLocation(WebGLProgram*, const String&);
@@ -708,6 +751,14 @@ class WebGL2RenderingContextBase : public WebGLRenderingContextBase {
GLsizei height,
GLenum format,
GLenum type,
+ DOMArrayBufferView* pixels,
+ GLuint offset);
+ void readPixels(GLint x,
+ GLint y,
+ GLsizei width,
+ GLsizei height,
+ GLenum format,
+ GLenum type,
long long offset);
/* WebGLRenderingContextBase overrides */
« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/webgl/WebGL2RenderingContextBase.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698