Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(188)

Issue 2456853002: Remove shortcut path fixups introduced to repair breakages caused by r378802. (Closed)

Created:
4 years, 1 month ago by grt (UTC plus 2)
Modified:
4 years, 1 month ago
Reviewers:
fdoray
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove shortcut path fixups introduced to repair breakages caused by r378802. This reverts "Fix the path of Chrome shortcuts from the installer." (04228a0), "Don't update Canary shortcuts from Dev/Beta/Stable installer." (a310422), and "Fix the path of shortcuts with an icon in the current install dir." (ff323ec). BUG=592040, 595374 R=fdoray@chromium.org Committed: https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497 Cr-Commit-Position: refs/heads/master@{#428110}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+9 lines, -540 lines) Patch
M chrome/installer/setup/install.h View 1 chunk +0 lines, -12 lines 0 comments Download
M chrome/installer/setup/install.cc View 4 chunks +1 line, -110 lines 0 comments Download
M chrome/installer/setup/install_unittest.cc View 5 chunks +0 lines, -349 lines 0 comments Download
M chrome/installer/util/install_util.h View 1 chunk +1 line, -17 lines 0 comments Download
M chrome/installer/util/install_util.cc View 3 chunks +7 lines, -14 lines 0 comments Download
M chrome/installer/util/install_util_unittest.cc View 1 chunk +0 lines, -38 lines 0 comments Download

Messages

Total messages: 11 (6 generated)
grt (UTC plus 2)
Hi Francois. Is it safe to remove all of this now, or should part of ...
4 years, 1 month ago (2016-10-27 11:14:21 UTC) #3
fdoray
lgtm
4 years, 1 month ago (2016-10-27 12:34:07 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2456853002/1
4 years, 1 month ago (2016-10-27 19:24:00 UTC) #8
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 1 month ago (2016-10-27 19:30:42 UTC) #9
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:34:46 UTC) #11
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/92470817cc0a5a126bc447e4777668f76b658497
Cr-Commit-Position: refs/heads/master@{#428110}

Powered by Google App Engine
This is Rietveld 408576698