Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1794)

Unified Diff: chrome/installer/util/install_util.h

Issue 2456853002: Remove shortcut path fixups introduced to repair breakages caused by r378802. (Closed)
Patch Set: Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/setup/install_unittest.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/util/install_util.h
diff --git a/chrome/installer/util/install_util.h b/chrome/installer/util/install_util.h
index 66a23d24882710f5af4b9384ddee4f829a3ca9b4..5862148ff3a9d73a345ef78f8cb5f530e25cf0b9 100644
--- a/chrome/installer/util/install_util.h
+++ b/chrome/installer/util/install_util.h
@@ -201,35 +201,19 @@ class InstallUtil {
// the same file.
class ProgramCompare : public RegistryValuePredicate {
public:
- enum class ComparisonType {
- // Evaluation compares existing files.
- FILE,
- // Evaluation compares existing files or directories.
- FILE_OR_DIRECTORY,
- };
-
- // Constructs a ProgramCompare with FILE as ComparisonType.
explicit ProgramCompare(const base::FilePath& path_to_match);
-
- // Constructs a ProgramCompare with |comparison_type| as ComparisonType.
- ProgramCompare(const base::FilePath& path_to_match,
- ComparisonType comparison_type);
-
~ProgramCompare() override;
bool Evaluate(const base::string16& value) const override;
bool EvaluatePath(const base::FilePath& path) const;
protected:
- static bool OpenForInfo(const base::FilePath& path,
- base::File* file,
- ComparisonType comparison_type);
+ static bool OpenForInfo(const base::FilePath& path, base::File* file);
static bool GetInfo(const base::File& file,
BY_HANDLE_FILE_INFORMATION* info);
base::FilePath path_to_match_;
base::File file_;
BY_HANDLE_FILE_INFORMATION file_info_;
- ComparisonType comparison_type_;
private:
DISALLOW_COPY_AND_ASSIGN(ProgramCompare);
« no previous file with comments | « chrome/installer/setup/install_unittest.cc ('k') | chrome/installer/util/install_util.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698