Remove shortcut path fixups introduced to repair breakages caused by r378802.

chrome/installer/setup/install.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/installer/setup/install.h"
 
 #include <windows.h>
 #include <shlobj.h>
 #include <time.h>
 
 #include <memory>
 #include <string>
 
 #include "base/command_line.h"
-#include "base/files/file_enumerator.h"
 #include "base/files/file_path.h"
 #include "base/files/file_util.h"
 #include "base/logging.h"
 #include "base/numerics/safe_conversions.h"
 #include "base/process/launch.h"
 #include "base/strings/string_util.h"
 #include "base/strings/stringprintf.h"
 #include "base/strings/utf_string_conversions.h"
 #include "base/win/shortcut.h"
 #include "base/win/windows_version.h"
 #include "chrome/common/chrome_constants.h"
 #include "chrome/common/chrome_switches.h"
 #include "chrome/installer/setup/install_worker.h"
 #include "chrome/installer/setup/installer_crash_reporting.h"
 #include "chrome/installer/setup/setup_constants.h"
 #include "chrome/installer/setup/setup_util.h"
 #include "chrome/installer/setup/update_active_setup_version_work_item.h"
 #include "chrome/installer/util/beacons.h"
 #include "chrome/installer/util/browser_distribution.h"
 #include "chrome/installer/util/create_reg_key_work_item.h"
 #include "chrome/installer/util/delete_after_reboot_helper.h"
 #include "chrome/installer/util/delete_old_versions.h"
 #include "chrome/installer/util/google_update_constants.h"
 #include "chrome/installer/util/helper.h"
 #include "chrome/installer/util/install_util.h"
 #include "chrome/installer/util/master_preferences.h"
 #include "chrome/installer/util/master_preferences_constants.h"
 #include "chrome/installer/util/set_reg_value_work_item.h"
-#include "chrome/installer/util/shell_util.h"
 #include "chrome/installer/util/util_constants.h"
 #include "chrome/installer/util/work_item.h"
 #include "chrome/installer/util/work_item_list.h"
 
 namespace {
 
 void LogShortcutOperation(ShellUtil::ShortcutLocation location,
                           BrowserDistribution* dist,
                           const ShellUtil::ShortcutProperties& properties,
                           ShellUtil::ShortcutOperation operation,
@@ skipping 205 matching lines @@
     return installer::OLD_VERSION_DOWNGRADE;
   }
 
   LOG(ERROR) << "Not sure how we got here while updating"
              << ", new version: " << new_version
              << ", old version: " << **current_version;
 
   return installer::INSTALL_FAILED;
 }
 
-// Returns the number of components in |file_path|.
-size_t GetNumPathComponents(const base::FilePath& file_path) {
-  std::vector<base::FilePath::StringType> components;
-  file_path.GetComponents(&components);
-  return components.size();
-}
-
-// Returns a path made with the |num_components| first components of
-// |file_path|. |file_path| is returned as-is if it contains less than
-// |num_components| components.
-base::FilePath TruncatePath(const base::FilePath& file_path,
-                            size_t num_components) {
-  std::vector<base::FilePath::StringType> components;
-  file_path.GetComponents(&components);
-  if (components.size() <= num_components)
-    return file_path;
-  base::FilePath truncated_file_path;
-  for (size_t i = 0; i < num_components; ++i)
-    truncated_file_path = truncated_file_path.Append(components[i]);
-  return truncated_file_path;
-}
-
-}  // namespace
+}  // end namespace
 
 namespace installer {
 
-void UpdatePerUserShortcutsInLocation(
-    const ShellUtil::ShortcutLocation shortcut_location,
-    BrowserDistribution* dist,
-    const base::FilePath& old_target_dir,
-    const base::FilePath& old_target_name_suffix,
-    const base::FilePath& new_target_path) {
-  base::FilePath shortcut_path;
-  const bool get_shortcut_path_return = ShellUtil::GetShortcutPath(
-      shortcut_location, dist, ShellUtil::CURRENT_USER, &shortcut_path);
-  DCHECK(get_shortcut_path_return);
-
-  bool recursive = false;
-
-  // TODO(fdoray): Modify GetShortcutPath such that it returns
-  // ...\Quick Launch\User Pinned instead of
-  // ...\Quick Launch\User Pinned\TaskBar for SHORTCUT_LOCATION_TASKBAR_PINS.
-  if (shortcut_location == ShellUtil::SHORTCUT_LOCATION_TASKBAR_PINS) {
-    shortcut_path = shortcut_path.DirName();
-    recursive = true;
-  }
-
-  const size_t num_old_target_dir_components =
-      GetNumPathComponents(old_target_dir);
-  InstallUtil::ProgramCompare old_target_dir_comparator(
-      old_target_dir,
-      InstallUtil::ProgramCompare::ComparisonType::FILE_OR_DIRECTORY);
-
-  base::FileEnumerator shortcuts_enum(shortcut_path, recursive,
-                                      base::FileEnumerator::FILES);
-  for (base::FilePath shortcut = shortcuts_enum.Next(); !shortcut.empty();
-       shortcut = shortcuts_enum.Next()) {
-    base::win::ShortcutProperties shortcut_properties;
-    if (!base::win::ResolveShortcutProperties(
-            shortcut, (base::win::ShortcutProperties::PROPERTIES_TARGET |
-                       base::win::ShortcutProperties::PROPERTIES_ICON),
-            &shortcut_properties)) {
-      continue;
-    }
-
-    if (shortcut_properties.target.ReferencesParent() ||
-        shortcut_properties.icon.ReferencesParent()) {
-      continue;
-    }
-
-    // Skip shortcuts whose target isn't a file rooted at |old_target_dir| with
-    // a name ending in |old_target_name_suffix|. Except for shortcuts whose
-    // icon is rooted at |old_target_dir|. Note that there can be a false
-    // negative if the target path or the icon path is a symlink.
-    // TODO(fdoray): The second condition is only intended to fix Canary
-    // shortcuts broken by crbug.com/595374, remove it in May 2016.
-    if (!(old_target_dir_comparator.EvaluatePath(TruncatePath(
-              shortcut_properties.target, num_old_target_dir_components)) &&
-          base::EndsWith(shortcut_properties.target.BaseName().value(),
-                         old_target_name_suffix.value(),
-                         base::CompareCase::INSENSITIVE_ASCII)) &&
-        !old_target_dir_comparator.EvaluatePath(TruncatePath(
-            shortcut_properties.icon, num_old_target_dir_components))) {
-      continue;
-    }
-
-    base::win::ShortcutProperties updated_properties;
-    updated_properties.set_target(new_target_path);
-    base::win::CreateOrUpdateShortcutLink(shortcut, updated_properties,
-                                          base::win::SHORTCUT_UPDATE_EXISTING);
-  }
-}
-
 void EscapeXmlAttributeValueInSingleQuotes(base::string16* att_value) {
   base::ReplaceChars(*att_value, base::ASCIIToUTF16("&"),
                      base::ASCIIToUTF16("&amp;"), att_value);
   base::ReplaceChars(*att_value, base::ASCIIToUTF16("'"),
                      base::ASCIIToUTF16("&apos;"), att_value);
   base::ReplaceChars(*att_value, base::ASCIIToUTF16("<"),
                      base::ASCIIToUTF16("&lt;"), att_value);
 }
 
 bool CreateVisualElementsManifest(const base::FilePath& src_path,
@@ skipping 147 matching lines @@
   if (base::PathExists(old_shortcut_path)) {
     ShellUtil::MoveExistingShortcut(
         ShellUtil::SHORTCUT_LOCATION_START_MENU_CHROME_DIR_DEPRECATED,
         ShellUtil::SHORTCUT_LOCATION_START_MENU_ROOT,
         dist, start_menu_properties);
   }
 
   ExecuteAndLogShortcutOperation(
       ShellUtil::SHORTCUT_LOCATION_START_MENU_ROOT, dist,
       start_menu_properties, shortcut_operation);
-
-  // Update the target path of existing per-user shortcuts. TODO(fdoray): This
-  // is only intended to fix Canary shortcuts broken by crbug.com/595374 and
-  // crbug.com/592040, remove it in May 2016.
-  if (InstallUtil::IsChromeSxSProcess() &&
-      install_operation == INSTALL_SHORTCUT_REPLACE_EXISTING) {
-    const base::FilePath updated_prefix = target.DirName().DirName();
-    const base::FilePath updated_suffix = target.BaseName();
-
-    UpdatePerUserShortcutsInLocation(ShellUtil::SHORTCUT_LOCATION_DESKTOP, dist,
-                                     updated_prefix, updated_suffix, target);
-    UpdatePerUserShortcutsInLocation(ShellUtil::SHORTCUT_LOCATION_QUICK_LAUNCH,
-                                     dist, updated_prefix, updated_suffix,
-                                     target);
-    UpdatePerUserShortcutsInLocation(ShellUtil::SHORTCUT_LOCATION_TASKBAR_PINS,
-                                     dist, updated_prefix, updated_suffix,
-                                     target);
-  }
 }
 
 void RegisterChromeOnMachine(const installer::InstallerState& installer_state,
                              const installer::Product& product,
                              bool make_chrome_default) {
   DCHECK(product.is_chrome());
 
   // Try to add Chrome to Media Player shim inclusion list. We don't do any
   // error checking here because this operation will fail if user doesn't
   // have admin rights and we want to ignore the error.
@@ skipping 268 matching lines @@
   // Read master_preferences copied beside chrome.exe at install.
   MasterPreferences prefs(installation_root.AppendASCII(kDefaultMasterPrefs));
   base::FilePath chrome_exe(installation_root.Append(kChromeExe));
   CreateOrUpdateShortcuts(
       chrome_exe, chrome, prefs, CURRENT_USER, install_operation);
 
   UpdateDefaultBrowserBeaconForPath(chrome_exe);
 }
 
 }  // namespace installer