Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(73)

Issue 2453953003: Moves TransientWindowClient to ui/aura/client and adds observer (Closed)

Created:
4 years, 1 month ago by sky
Modified:
4 years, 1 month ago
CC:
chromium-reviews, sadrul, yusukes+watch_chromium.org, tfarina, shuchen+watch_chromium.org, jam, sievers+watch_chromium.org, jbauman+watch_chromium.org, nona+watch_chromium.org, darin-cc_chromium.org, piman+watch_chromium.org, kalyank, danakj+watch_chromium.org, James Su
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Moves TransientWindowClient to ui/aura/client and adds observer Mus is going to need to use this from within aura, so I'm moving it to ui/aura/client. Additionally I'm moving creation of WmState to AuraTestHelper. Again, mus is going to need it aura test code already depends upon ui/wm, so I can't think of a reason not to do it everywhere. BUG=659155 TEST=covered by tests R=ben@chromium.org Committed: https://crrev.com/f8fcebc79eae73281b270ae26c8248f757fb0570 Cr-Commit-Position: refs/heads/master@{#428087}

Patch Set 1 #

Patch Set 2 : comment #

Patch Set 3 : more WMState creation #

Patch Set 4 : moar #

Patch Set 5 : merge #

Unified diffs Side-by-side diffs Delta from patch set Stats (+147 lines, -69 lines) Patch
M ash/test/ash_test_helper.h View 1 2 2 chunks +5 lines, -0 lines 0 comments Download
M ash/test/ash_test_helper.cc View 1 2 3 4 3 chunks +3 lines, -0 lines 0 comments Download
M content/browser/renderer_host/render_widget_host_view_aura.cc View 1 2 3 4 2 chunks +1 line, -1 line 0 comments Download
M content/shell/browser/shell.h View 1 2 3 2 chunks +5 lines, -0 lines 0 comments Download
M content/shell/browser/shell_views.cc View 1 2 3 4 chunks +23 lines, -7 lines 0 comments Download
M ui/aura/BUILD.gn View 1 2 3 4 2 chunks +3 lines, -2 lines 0 comments Download
A + ui/aura/client/transient_window_client.h View 4 chunks +7 lines, -5 lines 0 comments Download
A + ui/aura/client/transient_window_client.cc View 1 chunk +1 line, -1 line 0 comments Download
A ui/aura/client/transient_window_client_observer.h View 1 1 chunk +35 lines, -0 lines 0 comments Download
M ui/aura/test/DEPS View 1 chunk +1 line, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.h View 1 2 3 4 2 chunks +6 lines, -0 lines 0 comments Download
M ui/aura/test/aura_test_helper.cc View 1 2 3 4 4 chunks +3 lines, -1 line 0 comments Download
M ui/views/corewm/tooltip_controller_unittest.cc View 7 chunks +0 lines, -7 lines 0 comments Download
M ui/views/test/test_views_delegate.h View 2 chunks +0 lines, -8 lines 0 comments Download
M ui/views/test/test_views_delegate_aura.cc View 2 chunks +0 lines, -4 lines 0 comments Download
M ui/views/test/views_test_helper_aura.h View 2 chunks +0 lines, -5 lines 0 comments Download
M ui/views/test/views_test_helper_aura.cc View 3 chunks +0 lines, -3 lines 0 comments Download
M ui/wm/core/easy_resize_window_targeter.cc View 1 chunk +1 line, -1 line 0 comments Download
M ui/wm/core/focus_controller_unittest.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M ui/wm/core/shadow_controller_unittest.cc View 4 chunks +0 lines, -4 lines 0 comments Download
M ui/wm/core/transient_window_controller.h View 2 chunks +17 lines, -1 line 0 comments Download
M ui/wm/core/transient_window_controller.cc View 2 chunks +18 lines, -0 lines 0 comments Download
M ui/wm/core/transient_window_manager.cc View 3 chunks +13 lines, -1 line 0 comments Download
M ui/wm/core/transient_window_manager_unittest.cc View 3 chunks +0 lines, -13 lines 0 comments Download
M ui/wm/core/wm_state.h View 1 chunk +0 lines, -1 line 0 comments Download
M ui/wm/test/wm_test_helper.h View 1 2 2 chunks +2 lines, -0 lines 0 comments Download
M ui/wm/test/wm_test_helper.cc View 1 2 2 chunks +3 lines, -0 lines 0 comments Download

Messages

Total messages: 26 (21 generated)
sky
As part of this I'm making AuraTestHelper install WMState. This meant I could remove creating ...
4 years, 1 month ago (2016-10-27 17:02:23 UTC) #19
Ben Goodger (Google)
lgtm
4 years, 1 month ago (2016-10-27 18:25:11 UTC) #20
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2453953003/80001
4 years, 1 month ago (2016-10-27 18:26:35 UTC) #22
commit-bot: I haz the power
Committed patchset #5 (id:80001)
4 years, 1 month ago (2016-10-27 18:34:46 UTC) #24
commit-bot: I haz the power
4 years, 1 month ago (2016-10-27 19:01:33 UTC) #26
Message was sent while issue was closed.
Patchset 5 (id:??) landed as
https://crrev.com/f8fcebc79eae73281b270ae26c8248f757fb0570
Cr-Commit-Position: refs/heads/master@{#428087}

Powered by Google App Engine
This is Rietveld 408576698