[Findit] Using flake_analysis_service and add bug number to check flake UI

- Use flake_analysis_service to schedule an analysis of a flaky test
- Add support for passing a bug number through the UI
- Better malformed input handling/error messages

Old UI: http://findit-for-me.appspot.com/waterfall/flake

Updated UI: http://lijeffrey-dot-findit-for-me.appspot.com/waterfall/flake

BUG=660025
Committed: https://chromium.googlesource.com/infra/infra/+/0fbdc37dee3cab3461d0d3b96911ebd058ae7844

[lijeffrey, 2016-10-27 15:11:25]

Description was changed from

==========
[Findit] Adding support for passing bug number via Findit trigger flake analysis
UI

BUG=
==========

to

==========
- Use flake_analysis_service to schedule an analysis of a flaky test
- Add support for passing a bug number through the UI
- Better malformed input handling/error messages

BUG=660025
==========

[lijeffrey, 2016-10-27 15:11:26]

lijeffrey@chromium.org changed reviewers:
+ chanli@chromium.org

[lijeffrey, 2016-10-27 15:14:36]

Description was changed from

==========
- Use flake_analysis_service to schedule an analysis of a flaky test
- Add support for passing a bug number through the UI
- Better malformed input handling/error messages

BUG=660025
==========

to

==========
- Use flake_analysis_service to schedule an analysis of a flaky test
- Add support for passing a bug number through the UI
- Better malformed input handling/error messages

Old UI: http://findit-for-me.appspot.com/waterfall/flake

Updated UI: http://lijeffrey-dot-findit-for-me.appspot.com/waterfall/flake

BUG=660025
==========

[lijeffrey, 2016-10-27 15:14:46]

ptal

[chanli, 2016-10-27 17:53:52]

lgtm with a nit

https://codereview.chromium.org/2456033002/diff/1/appengine/findit/templates/...
File appengine/findit/templates/flake/flake.html (right):

https://codereview.chromium.org/2456033002/diff/1/appengine/findit/templates/...
appengine/findit/templates/flake/flake.html:64: <td style="text-align:right">Bug
ID:</td>
Since Bug ID is optional, should we change it to "Bug ID (optional)", or add
marks for the required fields?

[lijeffrey, 2016-10-27 20:29:13]

https://codereview.chromium.org/2456033002/diff/1/appengine/findit/templates/...
File appengine/findit/templates/flake/flake.html (right):

https://codereview.chromium.org/2456033002/diff/1/appengine/findit/templates/...
appengine/findit/templates/flake/flake.html:64: <td style="text-align:right">Bug
ID:</td>
On 2016/10/27 17:53:51, chanli wrote:
> Since Bug ID is optional, should we change it to "Bug ID (optional)", or add
> marks for the required fields?

Done.

[lijeffrey, 2016-10-27 20:29:27]

The CQ bit was checked by lijeffrey@chromium.org

[lijeffrey, 2016-10-27 20:29:27]

The patchset sent to the CQ was uploaded after l-g-t-m from chanli@chromium.org
Link to the patchset: https://codereview.chromium.org/2456033002/#ps20001
(title: "Addressing Comments")

[commit-bot: I haz the power, 2016-10-27 20:29:32]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-27 21:13:36]

Description was changed from

==========
- Use flake_analysis_service to schedule an analysis of a flaky test
- Add support for passing a bug number through the UI
- Better malformed input handling/error messages

Old UI: http://findit-for-me.appspot.com/waterfall/flake

Updated UI: http://lijeffrey-dot-findit-for-me.appspot.com/waterfall/flake

BUG=660025
==========

to

==========
- Use flake_analysis_service to schedule an analysis of a flaky test
- Add support for passing a bug number through the UI
- Better malformed input handling/error messages

Old UI: http://findit-for-me.appspot.com/waterfall/flake

Updated UI: http://lijeffrey-dot-findit-for-me.appspot.com/waterfall/flake

BUG=660025

Committed:
https://chromium.googlesource.com/infra/infra/+/0fbdc37dee3cab3461d0d3b96911e...
==========

[commit-bot: I haz the power, 2016-10-27 21:13:37]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/infra/infra/+/0fbdc37dee3cab3461d0d3b96911e...

[stgao, 2016-10-31 22:03:14]

stgao@chromium.org changed reviewers:
+ stgao@chromium.org

[stgao, 2016-10-31 22:03:16]

https://codereview.chromium.org/2456033002/diff/20001/appengine/findit/handle...
File appengine/findit/handlers/flake/check_flake.py (right):

https://codereview.chromium.org/2456033002/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/check_flake.py:119: analysis =
request.analyses[-1].get()
How do we plan to deal with the legacy data for this change?

[stgao, 2016-10-31 22:08:03]

https://codereview.chromium.org/2456033002/diff/20001/appengine/findit/handle...
File appengine/findit/handlers/flake/check_flake.py (right):

https://codereview.chromium.org/2456033002/diff/20001/appengine/findit/handle...
appengine/findit/handlers/flake/check_flake.py:119: analysis =
request.analyses[-1].get()
Will this always return the analysis for the master/builder/build_number in the
request line #71-75 above? If information could be mismatched, what could we
deal with that?

[stgao, 2016-11-02 21:03:59]

Jeff, what's your thoughts on my comments above?