[Findit] Using flake_analysis_service and add bug number to check flake UI

appengine/findit/handlers/flake/test/check_flake_test.py

Index: appengine/findit/handlers/flake/test/check_flake_test.py
diff --git a/appengine/findit/handlers/flake/test/check_flake_test.py b/appengine/findit/handlers/flake/test/check_flake_test.py
index 9900c7a3de2552ae5bb344523d64b232ffa29601..319f10888cb8c431e9d7b788e9152be1d5ab8639 100644
--- a/appengine/findit/handlers/flake/test/check_flake_test.py
+++ b/appengine/findit/handlers/flake/test/check_flake_test.py
@@ -12,10 +12,13 @@ import webtest
 from google.appengine.api import users
 
 from handlers.flake import check_flake
-from model.flake.master_flake_analysis import DataPoint
-from model.flake.master_flake_analysis import MasterFlakeAnalysis
+from handlers.flake.check_flake import CheckFlake
 from model import analysis_status
 from model.analysis_status import STATUS_TO_DESCRIPTION
+from model.flake.flake_analysis_request import FlakeAnalysisRequest
+from model.flake.master_flake_analysis import DataPoint
+from model.flake.master_flake_analysis import MasterFlakeAnalysis
+from waterfall.flake import flake_analysis_service
 from waterfall.test import wf_testcase
 
 
@@ -31,6 +34,10 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
     step_name = 's'
     test_name = 't'
 
+    analysis = MasterFlakeAnalysis.Create(
+        master_name, builder_name, build_number, step_name, test_name)
+    analysis.Save()
+
     self.mock_current_user(user_email='test@google.com')
 
     response = self.test_app.get('/waterfall/check-flake', params={
@@ -118,6 +125,118 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
     self.assertEquals(200, response.status_int)
     self.assertEqual(expected_check_flake_result, response.json_body)
 
+  def testUnauthorizedUserCannotScheduleNewAnalysis(self):
+    master_name = 'm'
+    builder_name = 'b'
+    build_number = 123
+    step_name = 's'
+    test_name = 't'
+
+    self.assertRaisesRegexp(
+        webtest.app.AppError,
+        re.compile('.*401 Unauthorized.*', re.MULTILINE | re.DOTALL),
+        self.test_app.get,
+        '/waterfall/check-flake',
+        params={
+            'master_name': master_name,
+            'builder_name': builder_name,
+            'build_number': build_number,
+            'step_name': step_name,
+            'test_name': test_name,
+            'format': 'json'})
+
+  @mock.patch.object(flake_analysis_service, 'ScheduleAnalysisForFlake',
+                     return_value=False)
+  def testRequestExistingAnalysis(self, _):
+    master_name = 'm'
+    builder_name = 'b'
+    build_number = 123
+    step_name = 's'
+    test_name = 't'
+    success_rate = 0.9
+
+    previous_analysis = MasterFlakeAnalysis.Create(
+        master_name, builder_name, build_number - 1, step_name, test_name)
+    data_point = DataPoint()
+    data_point.build_number = int(build_number)
+    data_point.pass_rate = success_rate
+    previous_analysis.data_points.append(data_point)
+    previous_analysis.status = analysis_status.COMPLETED
+    previous_analysis.suspected_flake_build_number = 100
+    previous_analysis.request_time = datetime.datetime(2016, 10, 01, 12, 10, 00)
+    previous_analysis.start_time = datetime.datetime(2016, 10, 01, 12, 10, 05)
+    previous_analysis.end_time = datetime.datetime(2016, 10, 01, 13, 10, 00)
+    previous_analysis.algorithm_parameters = {'iterations_to_rerun': 100}
+    previous_analysis.Save()
+
+    previous_request = FlakeAnalysisRequest.Create(test_name, False, None)
+    previous_request.AddBuildStep(
+        master_name, builder_name, build_number, step_name, None)
+    previous_request.analyses.append(previous_analysis.key)
+    previous_request.Save()
+
+    response = self.test_app.get('/waterfall/check-flake', params={
+        'master_name': master_name,
+        'builder_name': builder_name,
+        'build_number': build_number,
+        'step_name': step_name,
+        'test_name': test_name,
+        'format': 'json'})
+
+    expected_check_flake_result = {
+        'pass_rates': [[int(build_number), success_rate]],
+        'analysis_status': STATUS_TO_DESCRIPTION.get(previous_analysis.status),
+        'master_name': master_name,
+        'builder_name': builder_name,
+        'build_number': int(build_number),
+        'step_name': step_name,
+        'test_name': test_name,
+        'request_time': '2016-10-01 12:10:00 UTC',
+        'task_number': 1,
+        'error': None,
+        'iterations_to_rerun': 100,
+        'pending_time': '00:00:05',
+        'duration': '00:59:55',
+        'suspected_flake': {
+            'build_number': 100,
+            'triage_result': 0
+        },
+        'version_number': 1,
+        'show_debug_info': False
+    }
+
+    self.assertEqual(200, response.status_int)
+    self.assertEqual(expected_check_flake_result, response.json_body)
+
+  @mock.patch.object(flake_analysis_service, 'ScheduleAnalysisForFlake',
+                     return_value=False)
+  def testRequestUnsupportedAnalysis(self, _):
+    master_name = 'm'
+    builder_name = 'b'
+    build_number = 123
+    step_name = 's'
+    test_name = 't'
+
+    previous_request = FlakeAnalysisRequest.Create(test_name, False, None)
+    previous_request.AddBuildStep(
+        master_name, builder_name, build_number, step_name, None)
+    previous_request.swarmed = False
+    previous_request.supported = False
+    previous_request.Save()
+
+    self.assertRaisesRegexp(
+        webtest.app.AppError,
+        re.compile('.*not supported.*', re.MULTILINE | re.DOTALL),
+        self.test_app.get,
+        '/waterfall/check-flake',
+        params={
+            'master_name': master_name,
+            'builder_name': builder_name,
+            'build_number': build_number,
+            'step_name': step_name,
+            'test_name': test_name,
+            'format': 'json'})
+
   @mock.patch.object(users, 'is_current_user_admin', return_value=True)
   def testGetTriageHistory(self, _):
     master_name = 'm'
@@ -154,3 +273,39 @@ class CheckFlakeTest(wf_testcase.WaterfallTestCase):
     self.assertEqual(
         triage_history[0].get('suspect_info', {}).get('build_number'),
         suspected_flake_build_number)
+
+  def testValidateInput(self):
+    self.assertIsNone(
+        CheckFlake()._ValidateInput('m', 'b', '123', 's', 't', None))
+    self.assertIsNone(
+        CheckFlake()._ValidateInput('m', 'b', '123', 's', 't', '654321'))
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            None, 'b', '1', 's', 't', 'a').get('data', {}).get('error_message'),
+        'Master name must be specified')
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            'm', None, '1', 's', 't', '').get('data', {}).get('error_message'),
+        'Builder name must be specified')
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            'm', 'b', None, 's', 't', '').get('data', {}).get('error_message'),
+        'Build number must be specified as an int')
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            'm', 'b', 'a', 's', 't', '').get('data', {}).get('error_message'),
+        'Build number must be specified as an int')
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            'm', 'b', '1', None, 't', '').get('data', {}).get('error_message'),
+        'Step name must be specified')
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            'm', 'b', '1', 's', None, '').get('data', {}).get('error_message'),
+        'Test name must be specified')
+    self.assertEqual(
+        CheckFlake()._ValidateInput(
+            'm', 'b', '1', 's', 't', 'a').get('data', {}).get('error_message'),
+        'Bug id (optional) must be an int')
+
+