appengine/findit/waterfall/flake/flake_analysis_service.py - Issue 2456033002: [Findit] Using flake_analysis_service and add bug number to check flake UI

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: appengine/findit/waterfall/flake/flake_analysis_service.py

Issue 2456033002: [Findit] Using flake_analysis_service and add bug number to check flake UI (Closed)

Patch Set: Addressing Comments Created 4 years, 2 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: appengine/findit/waterfall/flake/flake_analysis_service.py

diff --git a/appengine/findit/waterfall/flake/flake_analysis_service.py b/appengine/findit/waterfall/flake/flake_analysis_service.py

index cf6d4214db934fb0f2ef86f7cb79dfac48775d66..9ca5e6e8d46e58de06cfaead18274e6ac28f18c8 100644

--- a/appengine/findit/waterfall/flake/flake_analysis_service.py

+++ b/appengine/findit/waterfall/flake/flake_analysis_service.py

@@ -204,6 +204,7 @@ def ScheduleAnalysisForFlake(request, user_email, is_admin, triggering_source):

version_number, build_step = _CheckForNewAnalysis(request)

if version_number and build_step:

# A new analysis is needed.

+ # TODO(lijeffrey): Add support for the force flag to trigger a rerun.

logging.info('A new analysis is needed for: %s', build_step)

analysis = initialize_flake_pipeline.ScheduleAnalysisIfNeeded(

build_step.wf_master_name, build_step.wf_builder_name,