chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm - Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

Issue 2455973006: Prevent popunders with the new auto-dismissing dialogs. (Closed)

Patch Set: with test Created 4 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

diff --git a/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm b/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

index ece29c7d01bb02fcf98f09193666f00b8f8c6249..10bc7b5d4d1fe0b8972e9b90303e5941414ad1f7 100644

--- a/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

+++ b/chrome/browser/ui/javascript_dialogs/javascript_dialog_cocoa.mm

@@ -178,7 +178,8 @@ JavaScriptDialogCocoa::JavaScriptDialogCocoa(

const base::string16& default_prompt_text,

const content::JavaScriptDialogManager::DialogClosedCallback&

dialog_callback)

- : impl_(base::MakeUnique<JavaScriptDialogCocoaImpl>(this,

+ : JavaScriptDialog(parent_web_contents),

+ impl_(base::MakeUnique<JavaScriptDialogCocoaImpl>(this,

parent_web_contents,

alerting_web_contents,

title,