[Sync] On disabling sync, device info records are removed.

[Sync] On disabling sync, device info records are removed.

BUG=659718
Committed: https://crrev.com/f6d4a1317c6258a509ab7883cf45ea7e141fba1c
Cr-Commit-Position: refs/heads/master@{#427838}

[skym, 2016-10-26 17:46:32]

The CQ bit was checked by skym@chromium.org to run a CQ dry run

[skym, 2016-10-26 17:46:58]

skym@chromium.org changed reviewers:
+ maxbogue@chromium.org, pavely@chromium.org

[skym, 2016-10-26 17:46:59]

PTAL. I'm not sure making DisableSync virtual is the best way to approach this.
Maybe we can talk in person today.

[commit-bot: I haz the power, 2016-10-26 17:47:03]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[maxbogue, 2016-10-26 18:18:30]

lgtm

https://codereview.chromium.org/2455693002/diff/20001/components/sync/device_...
File components/sync/device_info/device_info_service_unittest.cc (right):

https://codereview.chromium.org/2455693002/diff/20001/components/sync/device_...
components/sync/device_info/device_info_service_unittest.cc:787: service()
nit: pull the error out onto a separate line to make it clearer?

[skym, 2016-10-26 18:24:35]

https://codereview.chromium.org/2455693002/diff/20001/components/sync/device_...
File components/sync/device_info/device_info_service_unittest.cc (right):

https://codereview.chromium.org/2455693002/diff/20001/components/sync/device_...
components/sync/device_info/device_info_service_unittest.cc:787: service()
On 2016/10/26 18:18:30, maxbogue wrote:
> nit: pull the error out onto a separate line to make it clearer?

Done.

[skym, 2016-10-26 18:24:42]

The CQ bit was checked by skym@chromium.org

[skym, 2016-10-26 18:24:42]

The patchset sent to the CQ was uploaded after l-g-t-m from
maxbogue@chromium.org
Link to the patchset: https://codereview.chromium.org/2455693002/#ps40001
(title: "Updates for Max.")

[commit-bot: I haz the power, 2016-10-26 18:25:41]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 20:03:25]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-26 20:03:26]

Try jobs failed on following builders:
  linux_chromium_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[skym, 2016-10-26 21:21:36]

The CQ bit was checked by skym@chromium.org

[commit-bot: I haz the power, 2016-10-26 21:22:27]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-26 22:05:01]

Committed patchset #3 (id:40001)

[commit-bot: I haz the power, 2016-10-26 22:08:35]

Description was changed from

==========
[Sync] On disabling sync, device info records are removed.

BUG=659718
==========

to

==========
[Sync] On disabling sync, device info records are removed.

BUG=659718

Committed: https://crrev.com/f6d4a1317c6258a509ab7883cf45ea7e141fba1c
Cr-Commit-Position: refs/heads/master@{#427838}
==========

[commit-bot: I haz the power, 2016-10-26 22:08:36]

Patchset 3 (id:??) landed as
https://crrev.com/f6d4a1317c6258a509ab7883cf45ea7e141fba1c
Cr-Commit-Position: refs/heads/master@{#427838}