Chromium Code Reviews
|
|
Chromium Code Reviews
Issue
2458473002:
[Sync] Cleanup of device_info_service_unittest.cc (Closed)
Description[Sync] Cleanup of device_info_service_unittest.cc
* Replaced ASSERT_* with EXPECT_*
* Updated method names from Assert* to Verify*
* Removed some inline method calls and .IsSet() checks on errors
* In-lined many vector and maps
BUG=
Committed: https://crrev.com/3a6b7e88e7e9e41363fa151b6c72da5cd68c6557
Cr-Commit-Position: refs/heads/master@{#428018}
Patch Set 1 #
Depends on Patchset: Messages
Total messages: 17 (12 generated)
The CQ bit was checked by skym@chromium.org to run a CQ dry run
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Description was changed from ========== [Sync] Cleanup of device_info_service_unittest.cc BUG= ========== to ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced EXPECT_* with ASSERT_* * Updated method names from Expect* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps. BUG= ==========
Description was changed from ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced EXPECT_* with ASSERT_* * Updated method names from Expect* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps. BUG= ========== to ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced EXPECT_* with ASSERT_* * Updated method names from Expect* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ==========
skym@chromium.org changed reviewers: + maxbogue@chromium.org
PTAL
lgtm but these two lines of your description * Replaced EXPECT_* with ASSERT_* * Updated method names from Expect* to Verify* should be * Replaced ASSERT_* with EXPECT_* * Updated method names from Assert* to Verify*
Description was changed from ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced EXPECT_* with ASSERT_* * Updated method names from Expect* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ========== to ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* withEXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ==========
Description was changed from ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* withEXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ========== to ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* with EXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ==========
The CQ bit was unchecked by commit-bot@chromium.org
Dry run: Try jobs failed on following builders: linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED, https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)
The CQ bit was checked by skym@chromium.org
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...
Message was sent while issue was closed.
Description was changed from ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* with EXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ========== to ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* with EXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ==========
Message was sent while issue was closed.
Committed patchset #1 (id:1)
Message was sent while issue was closed.
Description was changed from ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* with EXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= ========== to ========== [Sync] Cleanup of device_info_service_unittest.cc * Replaced ASSERT_* with EXPECT_* * Updated method names from Assert* to Verify* * Removed some inline method calls and .IsSet() checks on errors * In-lined many vector and maps BUG= Committed: https://crrev.com/3a6b7e88e7e9e41363fa151b6c72da5cd68c6557 Cr-Commit-Position: refs/heads/master@{#428018} ==========
Message was sent while issue was closed.
Patchset 1 (id:??) landed as https://crrev.com/3a6b7e88e7e9e41363fa151b6c72da5cd68c6557 Cr-Commit-Position: refs/heads/master@{#428018} |
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
