Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(357)

Unified Diff: components/sync/model/model_type_service.h

Issue 2455693002: [Sync] On disabling sync, device info records are removed. (Closed)
Patch Set: Updates for Max. Created 4 years, 2 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/sync/device_info/device_info_service_unittest.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: components/sync/model/model_type_service.h
diff --git a/components/sync/model/model_type_service.h b/components/sync/model/model_type_service.h
index 9e63c8f571e47082d00f1156d9c98369074135a6..3d39d5b16687db84b56f7ea3e3bf599baf34813c 100644
--- a/components/sync/model/model_type_service.h
+++ b/components/sync/model/model_type_service.h
@@ -111,8 +111,7 @@ class ModelTypeService : public base::SupportsWeakPtr<ModelTypeService> {
// Indicates that we no longer want to do any sync-related things for this
// data type. Severs all ties to the sync thread, deletes all local sync
// metadata, and then destroys the change processor.
- // TODO(crbug.com/584365): This needs to be called from DataTypeController.
- void DisableSync();
+ virtual void DisableSync();
ModelTypeChangeProcessor* change_processor() const;
« no previous file with comments | « components/sync/device_info/device_info_service_unittest.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698