Reland of Improve linearized pdf load/show time.

Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method OnPendingRequestComplete is called, when we receive requested data (main connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
> http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509ec1ef2b31.pdf
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}

Original review:
https://codereview.chromium.org/2349753003/

Committed: https://crrev.com/3704ccf02007dd912933abc3f3006159171bc41b
Cr-Commit-Position: refs/heads/master@{#429514}

[snake, 2016-10-28 13:18:02]

Description was changed from

==========
Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was
added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we
can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data
using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method
OnPendingRequestComplete is called, when we receive requested data (main
connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
>
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509e...
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}
==========

to

==========
Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was
added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we
can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data
using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method
OnPendingRequestComplete is called, when we receive requested data (main
connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
>
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509e...
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}

Original review:
https://codereview.chromium.org/2349753003/
==========

[snake, 2016-10-28 13:18:02]

art-snake@yandex-team.ru changed reviewers:
+ rsesek@chromium.org, thestig@chromium.org

[snake, 2016-10-31 17:12:26]

On 2016/10/28 13:18:21, snake wrote:

ping?

[Lei Zhang, 2016-10-31 18:28:40]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 18:29:07]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-10-31 18:44:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 18:44:00]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_compile_dbg_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-10-31 18:52:34]

Now that the trybots are building pdf_unittests, they are showing linking
errors.

https://codereview.chromium.org/2455403002/diff/1/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/2455403002/diff/1/pdf/BUILD.gn#newcode50
pdf/BUILD.gn:50: # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
I removed this in https://crrev.com/427947 - let's not add it back in.

[snake, 2016-10-31 19:08:28]

https://codereview.chromium.org/2455403002/diff/1/pdf/BUILD.gn
File pdf/BUILD.gn (right):

https://codereview.chromium.org/2455403002/diff/1/pdf/BUILD.gn#newcode50
pdf/BUILD.gn:50: # TODO(jschuh): crbug.com/167187 fix size_t to int truncations.
On 2016/10/31 18:52:34, Lei Zhang wrote:
> I removed this in https://crrev.com/427947 - let's not add it back in.

Done.

[Lei Zhang, 2016-10-31 19:18:27]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-10-31 19:19:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[Lei Zhang, 2016-10-31 19:20:56]

I started another CQ dry run. Hope it turns green.

[Lei Zhang, 2016-10-31 21:57:31]

The ASAN but, which also runs LSAN, is complaining about memory leaks.

[Lei Zhang, 2016-10-31 21:57:40]

On 2016/10/31 21:57:31, Lei Zhang wrote:
> The ASAN but, which also runs LSAN, is complaining about memory leaks.

s/but/bot/

[commit-bot: I haz the power, 2016-10-31 22:18:13]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-10-31 22:18:14]

Dry run: Try jobs failed on following builders:
  linux_chromium_asan_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[snake, 2016-11-01 12:33:41]

On 2016/10/31 21:57:40, Lei Zhang wrote:
> On 2016/10/31 21:57:31, Lei Zhang wrote:
> > The ASAN but, which also runs LSAN, is complaining about memory leaks.
> 
> s/but/bot/

Fixed

[Lei Zhang, 2016-11-01 19:33:58]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-01 19:34:20]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-01 20:21:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-01 20:21:02]

Dry run: Try jobs failed on following builders:
  linux_chromium_chromeos_rel_ng on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Lei Zhang, 2016-11-01 20:52:43]

On 2016/11/01 12:33:41, snake wrote:
> On 2016/10/31 21:57:40, Lei Zhang wrote:
> > On 2016/10/31 21:57:31, Lei Zhang wrote:
> > > The ASAN but, which also runs LSAN, is complaining about memory leaks.
> > 
> > s/but/bot/
> 
> Fixed

Looks like the pdf/url_loader_wrapper_impl.cc fix now causes other errors.

[snake, 2016-11-02 12:12:12]

On 2016/11/01 20:52:43, Lei Zhang wrote:
> On 2016/11/01 12:33:41, snake wrote:
> > On 2016/10/31 21:57:40, Lei Zhang wrote:
> > > On 2016/10/31 21:57:31, Lei Zhang wrote:
> > > > The ASAN but, which also runs LSAN, is complaining about memory leaks.
> > > 
> > > s/but/bot/
> > 
> > Fixed
> 
> Looks like the pdf/url_loader_wrapper_impl.cc fix now causes other errors.

Should be fixed too.

[Lei Zhang, 2016-11-02 19:20:41]

The CQ bit was checked by thestig@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-11-02 19:21:28]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-02 22:03:19]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-02 22:03:21]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[snake, 2016-11-02 22:11:35]

On linux_android_rel_ng CustomTabActivityTest.testContextMenuEntriesForLink test
is failed. 
It is not related to my changes. What should i do in this case?

[Lei Zhang, 2016-11-02 23:56:58]

lgtm with a few more nits below.

Correct, the pdf/ changes here are unrelated to the failing Android bot.

https://codereview.chromium.org/2455403002/diff/60001/pdf/document_loader_uni...
File pdf/document_loader_unittest.cc (right):

https://codereview.chromium.org/2455403002/diff/60001/pdf/document_loader_uni...
pdf/document_loader_unittest.cc:33: // The objects, which create its, should be
destroyed at this moments.
The grammar is not 100% correct. Are you trying to say "The callbacks don't do
anything, because the objects that created the callbacks have been destroyed." ?

Same in URLLoaderWrapperImpl::~URLLoaderWrapperImpl().

https://codereview.chromium.org/2455403002/diff/60001/pdf/document_loader_uni...
pdf/document_loader_unittest.cc:262: class DocumentLoaderTest : public
::testing::Test {
Since everything here is empty, just:

using DocumentLoaderTest = ::testing::Test;

[snake, 2016-11-03 00:07:29]

https://codereview.chromium.org/2455403002/diff/60001/pdf/document_loader_uni...
File pdf/document_loader_unittest.cc (right):

https://codereview.chromium.org/2455403002/diff/60001/pdf/document_loader_uni...
pdf/document_loader_unittest.cc:33: // The objects, which create its, should be
destroyed at this moments.
On 2016/11/02 23:56:58, Lei Zhang wrote:
> The grammar is not 100% correct. Are you trying to say "The callbacks don't do
> anything, because the objects that created the callbacks have been destroyed."
?
> 
> Same in URLLoaderWrapperImpl::~URLLoaderWrapperImpl().

Done.

https://codereview.chromium.org/2455403002/diff/60001/pdf/document_loader_uni...
pdf/document_loader_unittest.cc:262: class DocumentLoaderTest : public
::testing::Test {
On 2016/11/02 23:56:58, Lei Zhang wrote:
> Since everything here is empty, just:
> 
> using DocumentLoaderTest = ::testing::Test;

Done.

[snake, 2016-11-03 00:07:37]

The CQ bit was checked by art-snake@yandex-team.ru

[snake, 2016-11-03 00:07:37]

The patchset sent to the CQ was uploaded after l-g-t-m from thestig@chromium.org
Link to the patchset: https://codereview.chromium.org/2455403002/#ps80001
(title: "Fix review issues")

[commit-bot: I haz the power, 2016-11-03 00:07:56]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 00:16:51]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-11-03 00:16:52]

Try jobs failed on following builders:
  chromium_presubmit on master.tryserver.chromium.linux (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.linux/builders/chromium_presub...)

[snake, 2016-11-03 00:27:59]

Robert Sesek, for ui/gfx/range/OWNERS - new pdf/DEPS entry

[Robert Sesek, 2016-11-03 00:28:20]

lgtm

[snake, 2016-11-03 01:02:34]

The CQ bit was checked by art-snake@yandex-team.ru

[commit-bot: I haz the power, 2016-11-03 01:03:14]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-11-03 02:13:45]

Description was changed from

==========
Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was
added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we
can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data
using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method
OnPendingRequestComplete is called, when we receive requested data (main
connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
>
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509e...
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}

Original review:
https://codereview.chromium.org/2349753003/
==========

to

==========
Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was
added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we
can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data
using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method
OnPendingRequestComplete is called, when we receive requested data (main
connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
>
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509e...
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}

Original review:
https://codereview.chromium.org/2349753003/
==========

[commit-bot: I haz the power, 2016-11-03 02:13:47]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-11-03 02:15:27]

Description was changed from

==========
Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was
added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we
can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data
using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method
OnPendingRequestComplete is called, when we receive requested data (main
connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
>
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509e...
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}

Original review:
https://codereview.chromium.org/2349753003/
==========

to

==========
Reland of Improve linearized pdf load/show time.

Original issue's description:
> Improve linearized pdf load/show time.
> Reduce Pdf Plugin's count of reconnects.
> Add tests for PDFPlugin DocumentLoader.
>
> DocumentLoader was splitted into separate components, and missing tests was
added for them.
>
> The main ideas in this CL are:
>
> 1) Do not reset browser initiated connection at start (includes case when we
can use range requests), if we request data near current downloading position.
> 2) Request as much data as we can on each request, and continue loading data
using current range request. (like tape rewind)
> 3) Isolate RangeRequest logic into DocumentLoader.  Method
OnPendingRequestComplete is called, when we receive requested data (main
connection, or Range connection). (like tape playing without rewing).
> 4) Fill this logic by tests.
>
> Example URL:
>
http://www.major-landrover.ru/upload/attachments/f/9/f96aab07dab04ae89c8a509e...
> Comparison of changes:
> https://drive.google.com/file/d/0BzWfMBOuik2QNGg0SG93Y3lpUlE/view?usp=sharing
>
> Committed: https://crrev.com/7fd7423cdee0dba84faf480d10dd66dcb57110d9
> Cr-Commit-Position: refs/heads/master@{#427752}

Original review:
https://codereview.chromium.org/2349753003/

Committed: https://crrev.com/3704ccf02007dd912933abc3f3006159171bc41b
Cr-Commit-Position: refs/heads/master@{#429514}
==========

[commit-bot: I haz the power, 2016-11-03 02:15:29]

Patchset 5 (id:??) landed as
https://crrev.com/3704ccf02007dd912933abc3f3006159171bc41b
Cr-Commit-Position: refs/heads/master@{#429514}

[dsinclair, 2016-12-05 18:29:42]

A revert of this CL (patchset #5 id:80001) has been created in
https://codereview.chromium.org/2551153002/ by dsinclair@chromium.org.

The reason for reverting is: Breaks loading of linearized Dynamic XFA documents.
e.g. The 'Dynamic Form Sample' on
https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/ breaks
when loaded through the website. It loads correctly off of disk..

[dsinclair, 2016-12-06 21:38:15]

On 2016/12/05 18:29:42, dsinclair wrote:
> A revert of this CL (patchset #5 id:80001) has been created in
> https://codereview.chromium.org/2551153002/ by mailto:dsinclair@chromium.org.
> 
> The reason for reverting is: Breaks loading of linearized Dynamic XFA
documents.
> e.g. The 'Dynamic Form Sample' on
> https://www.idrsolutions.com/jpdfforms/xfa-html5-example-conversions/ breaks
> when loaded through the website. It loads correctly off of disk..

I ended up needing to revert this as I couldn't get the form to work correctly
with this code. The revert is in https://codereview.chromium.org/2558573002/.